Skip to content

GCC style fallthrough attribute is used with clang versions that don't support it #128902

Closed
Closed
GCC style fallthrough attribute is used with clang versions that don't support it#128902
Labels
3.14bugs and security fixesbuildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or error

Description

@jmroot
jmroot
opened on Jan 16, 2025

Bug report

Bug description:

Include/pyport.h currently only guards use of __attribute__((fallthrough)) with _Py__has_attribute(fallthrough). Clang versions prior to 10 do not support this syntax, but do claim to support the fallthrough attribute (because they support the C++11 style [[fallthrough]]).

CPython versions tested on:

3.14

Operating systems tested on:

macOS

Linked PRs

Activity

  1. jmroot
    added
    type-bugAn unexpected behavior, bug, or error
    on Jan 16, 2025
  2. ZeroIntensity
    added
    buildThe build process and cross-build
    3.12only security fixes
    3.13only security fixes
    3.14bugs and security fixes
    and removed
    3.12only security fixes
    3.13only security fixes
    on Jan 16, 2025

  3. ZeroIntensity commented on Jan 16, 2025

    @ZeroIntensity
    ZeroIntensity
    on Jan 16, 2025
    Member

    Looks like this was done in #121044

    cc @sobolevn @vstinner

  4. ned-deily
    added a commit that references this issue on Jan 22, 2025

    gh-128902: Fix check for fallthrough attribute support (#128903)

    edf8033

  5. ned-deily commented on Jan 22, 2025

    @ned-deily
    ned-deily
    on Jan 22, 2025
    Member

    Fixed in #128903 edf8033 for 3.14.0a5

  6. ned-deily
    closed this as completedon Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.14bugs and security fixesbuildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions