Skip to content

New compute-changes.py should be checked with mypy #129707

Closed
Closed
New compute-changes.py should be checked with mypy#129707
Assignees
sobolevn
Labels
buildThe build process and cross-buildtype-featureA feature request or enhancement

Description

@sobolevn
sobolevn
opened on Feb 5, 2025

Feature or enhancement

Right now we have a special mypy.ini in Tools/build:

cpython/Tools/build/mypy.ini

Line 2 in cdcacec

files = Tools/build/generate_sbom.py

But, it only checks one file. Since newly added https://github.com/python/cpython/blob/main/Tools/build/compute-changes.py is fully annotated, it should be included as well.

Refs #129627

I will send a PR.

Linked PRs

Activity

  1. sobolevn
    added
    buildThe build process and cross-build
    type-featureA feature request or enhancement
    on Feb 5, 2025
  2. sobolevn
    self-assigned this
    on Feb 5, 2025
  3. sobolevn
    added a commit that references this issue on Feb 5, 2025

    pythongh-129707: Check `Tools/build/compute-changes.py` with `mypy`

    9df9a98
  4. AA-Turner
    added a commit that references this issue on Feb 6, 2025

    gh-129707: Check `Tools/build/compute-changes.py` with `mypy` (#129708)

    8b2fb62
  5. AA-Turner
    closed this as completedon Feb 6, 2025
  6. srinivasreddy
    added a commit that references this issue on Feb 7, 2025

    pythongh-129707: Check `Tools/build/compute-changes.py` with `mypy` (p…

    cea3635
  7. cmaloney
    added a commit that references this issue on Feb 8, 2025

    pythongh-129707: Check `Tools/build/compute-changes.py` with `mypy` (p…

    37ad7c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

buildThe build process and cross-buildtype-featureA feature request or enhancement

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions