Activity

1. chris-eibl

   added

   type-featureA feature request or enhancementA feature request or enhancement

   on Feb 13, 2025
2. encukou

   added

   OS-windows

   on Feb 14, 2025
3. picnixz

   added

   buildThe build process and cross-buildThe build process and cross-build

   on Feb 21, 2025
4. zooba

   added a commit that references this issue on Mar 4, 2025

   gh-130090: Support PGO for clang-cl on Windows (GH-129907)

   d8a1cf4
5. zooba commented on Mar 4, 2025

   

   zooba

   on Mar 4, 2025

   Member

   More actions

   This is now checked in, at least for 32-bit and 64-bit and natively-built ARM64 (cross-compiled ARM64 apparently needs some options that we don't know right now).

   Thanks @chris-eibl!

   ❤️React with ❤️2Reacted by Chris Eibl and Ken Jin

   🚀React with 🚀2Reacted by Chris Eibl and Ken Jin
6. zooba

   closed this as completedon Mar 4, 2025
7. chris-eibl commented on Mar 10, 2025

   

   chris-eibl

   on Mar 10, 2025

   MemberAuthor

   More actions

   @zanieb asked for build time numbers in #129907 (comment):

   Numbers in the following tables represent seconds. Please note that the sum of the detailed project times does not match the total time, because most of the projects are built in parallel, except _freeze_module and python314. Therefore, I have listed them first in the details table and then sorted the others by build time of the first column, see #131005.

   In the pgupdate details we still see _freeze_module, because #130420 is not on that branch. Hence, we see what that PR saves us.

   I intentionally branched off commit 9db1a29 to have the same environment.

   • MSVC is much faster for both debug and release builds
   • older clangs are faster than newer in debug builds

   Debug build times:

   	debug_clang_18.1.8	debug_clang_19.1.1	debug_clang_20.1.0-rc2	debug_msvc
   total time	128.3	154.8	163.5	84.9

   Release build times:

   	release_clang_18.1.8	release_clang_19.1.1	release_clang_20.1.0-rc2	release_msvc
   total time	278.3	277.2	274.2	172.3

   PGO build times:

   • MSVC is still faster in the pginstr phase
   • but the instrumented binaires take much longer to execute (pgo as short for pgo task in the table)
   • kill is due to call :Kill in case of build.bat --pgo - can be ignored, takes almost no time
   • pgupd phase takes longer for MSVC
   • so the overall build.bat --pgo times are longer for MSVC

   	pgo_clang_18.1.8	pgo_clang_19.1.1	pgo_clang_20.1.0-rc2	pgo_clang_thin_20.1.0-rc2	pgo_msvc
   pginstr	288.7	279.5	297.2	219.3	155.9
   pgo	77.0	70.0	70.0	69.0	559.0
   kill	1.1	1.2	1.2	0.5	1.1
   pgupd	284.8	271.5	282.8	231.7	359.0
   total time	651.7	622.1	651.2	520.6	1075.0

   Very interesting: pyexpat _elementtree take much longer for 20.1.0-rc2 in the pginstr phase (see details), but come back to "normal" with --flto=thin. Because these are so outliers, I retested several times with the same result :-O

   Detailed build times:

   Detailed debug build times

   	debug_clang_18.1.8	debug_clang_19.1.1	debug_clang_20.1.0-rc2	debug_msvc
   _freeze_module	31.0	36.5	38.5	16.8
   python314	44.9	56.5	62.7	31.4
   liblzma	14.8	15.7	14.3	7.5
   sqlite3	8.7	8.0	7.8	6.9
   _bz2	5.2	6.4	5.1	7.7
   _wmi	5.0	5.3	4.5	4.7
   _ctypes	5.0	5.9	5.7	7.9
   _decimal	4.2	5.5	5.2	3.4
   _testcapi	4.0	6.4	7.0	2.2
   _ssl	3.4	5.0	3.8	2.3
   _overlapped	3.1	3.9	3.6	2.5
   _uuid	3.1	1.9	4.2	4.0
   _socket	3.0	3.3	3.0	4.7
   _tkinter	3.0	3.6	3.5	2.2
   _sqlite3	2.9	4.0	4.2	1.4
   _hashlib	2.4	2.9	2.8	4.2
   venvwlauncher	2.4	2.8	2.8	4.5
   _elementtree	2.4	2.8	2.5	2.3
   _testlimitedcapi	2.3	3.6	3.9	1.4
   _multiprocessing	2.3	3.0	2.6	1.8
   _asyncio	2.3	2.8	2.7	3.5
   pyshellext	2.2	2.3	2.4	3.3
   _zoneinfo	2.1	2.7	2.5	3.1
   unicodedata	2.0	2.2	2.0	2.9
   py	1.9	2.1	2.2	3.7
   pyw	1.9	2.1	2.2	4.0
   _queue	1.9	2.0	2.1	3.5
   venvlauncher	1.9	1.9	1.5	3.8
   pyexpat	1.8	1.7	1.6	1.8
   _ctypes_test	1.6	1.6	1.7	1.1
   select	1.6	1.7	2.3	2.9
   _testinternalcapi	1.5	2.0	2.0	1.1
   winsound	1.4	1.8	1.7	7.5
   _testclinic	1.1	1.3	1.4	0.8
   _testembed	1.0	1.2	1.3	0.8
   pythonw	0.9	1.1	1.1	0.7
   _testconsole	0.8	1.0	1.1	0.7
   _testbuffer	0.8	0.9	1.0	0.6
   _lzma	0.8	1.0	1.1	1.1
   _testimportmultiple	0.7	0.8	0.9	0.5
   python	0.7	1.4	1.0	0.6
   _testmultiphase	0.7	0.9	1.0	0.6
   _testclinic_limited	0.7	0.8	0.9	0.5
   _testsinglephase	0.7	0.9	1.0	0.6
   python3	0.5	0.5	0.5	0.5
   total	186.8	221.8	227.1	169.8

   Detailed release build times

   	release_clang_18.1.8	release_clang_19.1.1	release_clang_20.1.0-rc2	release_msvc
   _freeze_module	26.4	35.5	37.6	13.8
   python314	147.0	135.6	131.0	98.2
   sqlite3	50.5	45.8	44.2	18.8
   liblzma	14.6	15.3	15.3	11.7
   _decimal	10.9	11.0	10.8	7.0
   _bz2	7.4	7.8	7.2	11.5
   _ctypes	7.3	7.3	7.2	9.7
   _testcapi	6.0	7.9	8.3	2.7
   pyexpat	5.6	5.0	4.3	5.9
   _ssl	5.0	5.3	5.5	5.2
   _wmi	4.8	4.4	5.0	6.2
   _tkinter	4.4	4.4	4.3	6.0
   _ctypes_test	3.9	3.7	3.6	6.3
   _socket	3.8	4.0	4.3	5.1
   _elementtree	3.5	3.5	3.6	5.0
   _uuid	3.4	5.0	4.0	5.2
   _testlimitedcapi	3.4	4.5	4.8	2.7
   _lzma	3.3	3.0	3.1	6.0
   _asyncio	3.3	3.5	3.5	1.9
   _hashlib	3.0	3.3	3.7	4.9
   _overlapped	3.0	3.2	3.4	3.4
   venvwlauncher	2.8	3.0	2.8	6.0
   _zoneinfo	2.7	4.0	3.1	4.8
   pyw	2.6	2.8	2.8	6.4
   unicodedata	2.5	2.5	2.4	2.6
   _sqlite3	2.4	3.1	3.1	1.4
   py	2.4	2.5	2.6	3.4
   pyshellext	2.4	2.7	2.7	6.0
   _multiprocessing	2.0	2.7	1.9	3.3
   _testclinic	2.0	2.0	2.0	1.0
   _testinternalcapi	1.9	2.3	2.4	1.2
   venvlauncher	1.9	1.8	1.9	3.5
   _queue	1.6	2.3	2.4	2.3
   select	1.5	1.6	1.6	2.6
   _testembed	1.3	1.5	1.5	0.8
   winsound	1.2	1.7	1.9	7.6
   _testbuffer	1.2	1.4	1.4	0.7
   _testconsole	0.8	1.1	1.2	0.7
   pythonw	0.8	1.1	1.1	0.7
   _testmultiphase	0.8	1.0	1.0	0.6
   _testsinglephase	0.7	0.9	1.0	0.6
   _testclinic_limited	0.7	0.9	0.9	0.5
   python	0.7	0.9	1.0	0.6
   _testimportmultiple	0.6	0.9	0.9	0.5
   xxlimited	0.6	0.9	0.8	0.5
   xxlimited_35	0.6	0.8	0.8	0.5
   python3	0.5	0.5	0.5	0.4
   total	359.9	365.9	360.3	296.1

   Details pginstrument build times

   	pgo_clang_18.1.8	pgo_clang_19.1.1	pgo_clang_20.1.0-rc2	pgo_clang_thin_20.1.0-rc2	pgo_msvc
   _freeze_module	26.6	35.1	38.5	40.0	14.0
   python314	159.6	139.7	141.5	81.3	86.6
   sqlite3	50.0	45.1	46.0	42.4	18.2
   _ctypes	14.3	8.6	6.9	7.5	8.1
   _bz2	12.7	8.4	7.0	4.9	6.1
   liblzma	12.7	18.3	18.2	16.5	11.3
   _decimal	11.4	10.9	12.4	7.7	3.6
   pyexpat	10.4	6.1	52.7	3.9	6.2
   _testcapi	5.8	7.6	8.3	7.1	2.7
   _asyncio	5.5	4.4	4.0	5.2	3.4
   _elementtree	5.0	5.4	51.8	5.3	3.2
   _wmi	4.9	6.1	4.5	3.0	5.7
   _lzma	4.5	3.5	3.8	1.8	6.2
   _ssl	3.9	5.6	3.7	5.5	5.6
   _ctypes_test	3.9	3.6	3.7	3.4	6.3
   venvwlauncher	3.6	2.8	3.3	2.7	4.1
   _testlimitedcapi	3.4	4.4	4.9	4.3	2.7
   _sqlite3	3.0	3.4	3.4	2.8	1.4
   _overlapped	2.9	3.2	4.5	3.2	2.5
   _zoneinfo	2.9	3.6	3.1	3.4	3.3
   _socket	2.8	4.2	2.4	3.7	4.6
   unicodedata	2.7	2.6	2.7	3.0	2.4
   _tkinter	2.6	4.6	2.2	4.1	3.4
   _multiprocessing	2.5	1.7	3.5	2.7	9.8
   pyw	2.4	2.8	2.7	2.7	3.2
   py	2.4	2.5	2.6	2.5	3.2
   pyshellext	2.3	2.8	2.7	2.6	2.9
   _testclinic	2.0	2.0	2.0	1.9	1.0
   _hashlib	1.9	3.3	1.8	3.1	5.0
   _testinternalcapi	1.8	2.2	2.4	2.2	1.2
   venvlauncher	1.7	1.8	1.8	1.7	2.7
   select	1.4	1.6	1.8	2.2	2.3
   _uuid	1.4	1.6	1.6	3.2	2.4
   _queue	1.4	1.7	1.6	2.3	2.8
   winsound	1.4	1.6	1.7	3.3	2.4
   _testembed	1.3	1.4	1.5	1.5	0.8
   _testbuffer	1.3	1.3	1.4	1.3	0.7
   _testconsole	0.8	1.0	1.1	1.1	0.7
   pythonw	0.8	1.1	1.1	1.1	0.7
   _testmultiphase	0.7	0.9	1.0	1.0	0.6
   _testsinglephase	0.7	0.9	1.0	1.0	0.6
   _testclinic_limited	0.7	0.9	0.9	0.9	0.6
   python	0.7	0.9	1.0	0.9	0.6
   _testimportmultiple	0.6	0.8	0.9	0.9	0.6
   python3	0.5	0.5	0.5	0.5	0.5
   total	385.7	372.4	465.8	303.3	257.1

   Details pgupdate build times

   	pgo_clang_18.1.8	pgo_clang_19.1.1	pgo_clang_20.1.0-rc2	pgo_clang_thin_20.1.0-rc2	pgo_msvc
   _freeze_module	26.7	34.7	38.0	39.5	13.8
   python314	154.3	137.6	141.9	95.4	287.1
   sqlite3	47.4	46.1	44.4	42.9	16.1
   _ctypes	12.1	6.9	8.0	7.2	6.3
   liblzma	12.0	16.6	17.3	16.5	7.9
   _bz2	11.0	7.1	7.8	5.5	9.1
   _decimal	10.0	10.8	11.2	8.7	6.1
   _testcapi	6.0	7.6	8.6	7.3	2.7
   pyexpat	5.3	4.4	4.6	3.6	4.7
   _elementtree	4.1	3.4	3.5	4.5	12.0
   _lzma	4.1	3.3	3.2	1.9	4.8
   _ctypes_test	3.8	3.6	3.7	3.4	6.4
   unicodedata	3.6	4.1	3.2	3.0	3.0
   venvwlauncher	3.5	2.8	3.1	3.0	5.2
   _testlimitedcapi	3.4	4.4	5.0	4.2	2.7
   _ssl	3.3	5.1	5.2	5.6	2.6
   _asyncio	3.0	4.7	4.5	4.6	3.4
   _overlapped	2.9	2.9	3.5	3.7	7.2
   _uuid	2.9	3.4	2.6	2.8	7.2
   _zoneinfo	2.8	3.1	3.2	3.2	2.5
   _wmi	2.6	3.3	3.5	3.1	5.3
   _sqlite3	2.6	2.9	3.1	2.7	1.7
   pyw	2.4	2.5	2.6	2.6	2.7
   _socket	2.4	3.8	4.3	3.5	14.6
   py	2.3	2.5	2.6	2.7	2.5
   pyshellext	2.3	2.5	2.7	2.6	2.4
   _tkinter	2.2	3.6	4.0	4.2	4.4
   _testclinic	2.0	2.0	2.0	1.9	1.0
   _testinternalcapi	1.9	2.2	2.4	2.2	1.2
   venvlauncher	1.7	1.6	1.7	1.5	2.4
   _multiprocessing	1.5	1.8	2.8	2.6	2.7
   select	1.5	1.6	1.6	2.0	3.5
   _queue	1.5	1.7	1.9	2.2	2.5
   _hashlib	1.5	3.5	3.1	3.3	3.2
   winsound	1.3	1.6	1.8	3.0	4.5
   _testembed	1.3	1.5	1.5	1.4	0.8
   _testbuffer	1.2	1.3	1.4	1.3	0.8
   _testconsole	0.8	1.1	1.1	1.0	0.7
   pythonw	0.8	1.0	1.1	1.1	0.7
   _testmultiphase	0.7	1.0	1.0	1.1	0.6
   _testsinglephase	0.7	0.9	1.0	1.0	0.6
   python	0.7	0.9	1.0	0.9	0.6
   _testclinic_limited	0.6	0.9	0.9	0.9	0.6
   _testimportmultiple	0.6	0.8	0.9	0.9	0.6
   python3	0.5	0.5	0.5	0.5	0.4
   total	360.0	359.7	372.9	316.8	472.1

   ❤️React with ❤️1Reacted by Zanie Blue