Repository navigation
Colorize sqlite3 CLI #133447
Description
Feature or enhancement
Proposal:
I will open a pr once #133393 is complete.
General idea is to follow repl color scheme:
sqlite>: repl magenta (i.e. >>>)
keywords: repl keyword blue (i.e. def)
.quit/.help: repl turquoise (i.e. exit)
rest: no color
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Activity
hugovk commentedon May 5, 2025
See also theming support, which will hopefully be merged soon: issue #133346 / PR #133347.
ambv commentedon May 5, 2025
I like how Stan is already talking in terms of semantic classes.
StanFromIreland commentedon May 5, 2025
Unfortunately the code currently uses a subclass of
InteractiveConsole(color support anytime soon? ;-) so I would have to write araw_input, but that still has to wait for the other pr ideally.For now I will open a pr adding color to the line starts as it is not depending on the pr. (Progressing like pyrepl coloring...)
StanFromIreland commentedon May 9, 2025
This is not in the sqlite3 project.
cc @ezio-melotti Can the project be set up to add them when the label is used topic-sqlite3, it would be a good test for the github workflow-like automations for projects that we discussed earlier?
ezio-melotti commentedon May 10, 2025
Done!
Details
I enabled the auto-add workflow:which matches 7 issues -- including this one -- but doesn't add them unless they are updated or newly created:
Note: after enabling the workflow and posting this message, the issue wasn't added to the workflow, so I added it manually. The GitHub docs are not clear on what "updated" means (apparently posting a message doesn't count as an update).
Note: I initially added
in:titleto the auto-add workflow query, but I got an error stating that it's invalid. Even after removing it, the query matches 7 issues, even though when I follow the "See 7 existing issues" link I get 50 issues. I now reported this issue to GitHub.StanFromIreland commentedon May 10, 2025
That is odd, maybe it only checks on title modifications?
We could add on the label addition instead like other projects.
gh-133447: Add basic color to `sqlite3` CLI (#133461)
ezio-melotti commentedon May 10, 2025
Done, and it seems it work on label addition (tested on #129926).
cherry pick from and resolve conflicts with 30b1d8f on main branch
encukou commentedon Jun 13, 2025
The new sqlite CLI allows spaces between a dot and the command:
I don't think that was an intentional change?
erlend-aasland commentedon Jun 13, 2025
I believe @serhiy-storchaka merged the change that opened up allowing this.
StanFromIreland commentedon Jun 13, 2025
For reference, the issue: #133439, the commit: ebd4881
It also has several other errors, like no spacing between words in the error message. (I have a pr to fix these: #133807)
serhiy-storchaka commentedon Jun 13, 2025
It was intentional. The SQLite CLI allows this.
encukou commentedon Jun 26, 2025
Thank you for the fix!
Is there anything more to do for this issue?
StanFromIreland commentedon Jun 26, 2025
The goal for this issue was:
and so far we have:
Though realistically if we do want to implement this, it shouldn't be in sqlite3 because it will just create a mess and add too much complex logic to maintain (in a module that should not have it), especially with the tab completion now.
So I propose to just add a Whats New note like was done in 3.13 for the REPL, and we can always reopen in the future.
gh-133447: Update `sqlite3` What's New 3.15 entry (GH-136079)
pythongh-133447: Update `sqlite3` What's New 3.15 entry (pythonGH-136079
pythongh-133447: Add basic color to `sqlite3` CLI (python#133461)
pythongh-133447: Update `sqlite3` What's New 3.15 entry (pythonGH-136079
pythongh-133447: Update `sqlite3` What's New 3.15 entry (pythonGH-136079
pythongh-133447: Add basic color to `sqlite3` CLI (python#133461)
pythongh-133447: Update `sqlite3` What's New 3.15 entry (pythonGH-136079
pythongh-133447: Update `sqlite3` What's New 3.15 entry (pythonGH-136079