Repository navigation
Implement frozendict for partialobject in functools module #145478
Description
Activity
This sounds like a reasonable approach. Immutable dictionaries can provide early detection or prevention for a number of subtle problems, especially those arising from free-threading.
Reacted by Brij KapadiaUpdate: While I was working on this issue, I found that it would be convenient to have a way to convert a
frozendictto adictsince a normal keywords dictionary is needed when calling functions. As such, I am waiting to create a PR until #145531 is merged.it would be convenient to have a way to convert a frozendict to a dict
Currently, you can use
dict = PyObject_CallOneArg((PyObject*)&PyDict_Type, frozendict);which calls thedictconstructor. In my PR gh-145531, I proposed addingPyAnyDict_AsNewDict()function for that.Reacted by Brij Kapadia
Feature or enhancement
Proposal:
After discussion on PR #145362, it became clear that there are many possibilities for unintended mutations in the
partialobjectinModule/_functoolsmodule.c, particularly for thekwdictionary for keywords. Thus, changingkwto be afrozendictcould prevent any unintended consequences.Additionally, right now, the keys of
kwcould be an arbitraryPyObject, leading to unintended code execution if they are not strings. Thus, enforcing that the entries are strings could solve any future problems (similar to what happened in #145362).Lastly, Issue #145446 also makes sure that there are no unintended mutations in the
functoolsinternals for free-threading, but changing to using afrozendictwould be a more robust solution.I will work on this and create a PR in the next couple of days. I will wait until #145446 is resolved to avoid any conflicts.
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
#145362 (comment)
Linked PRs
frozendictintofunctools.partial#145960