Skip to content

ISO date errors in _strptime are jumbled #81140

Closed
Closed
ISO date errors in _strptime are jumbled#81140
Labels
3.11only security fixes3.12only security fixes3.13only security fixesstdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

Description

@GPHemsley
GPHemsley
mannequin
opened on May 18, 2019
BPO 36959
Nosy @pganssle, @GPHemsley
PRs
  • bpo-36959: Fix checks for invalid ISO date formats in _strptime #13408
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2019-05-18.19:46:43.829>
labels = ['tests', '3.8', 'library']
title = 'ISO date errors in _strptime are jumbled'
updated_at = <Date 2019-05-19.01:10:45.613>
user = 'https://github.com/GPHemsley'

    bugs.python.org fields:

    activity = <Date 2019-05-19.01:10:45.613>
actor = 'gphemsley'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)', 'Tests']
creation = <Date 2019-05-18.19:46:43.829>
creator = 'gphemsley'
dependencies = []
files = []
hgrepos = []
issue_num = 36959
keywords = ['patch']
message_count = 5.0
messages = ['342810', '342811', '342812', '342816', '342828']
nosy_count = 2.0
nosy_names = ['p-ganssle', 'gphemsley']
pr_nums = ['13408']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue36959'
versions = ['Python 3.8']

    Activity

    1. GPHemsley commented on May 18, 2019

      @GPHemsley
      GPHemsleymannequin
      on May 18, 2019
      MannequinAuthor

      This has not been apparent because the tests for this code are not testing what they think they're testing.

    2. GPHemsley
      added
      3.8 (EOL)end of life
      stdlibStandard Library Python modules in the Lib/ directory
      testsTests in the Lib/test dir
      on May 18, 2019

    3. pganssle commented on May 18, 2019

      @pganssle
      pganssle
      on May 18, 2019
      Member

      @gphelmsley Can you clarify what you mean by this?

      Do you have a minimal reproducing example that shows what's happening and what you are expecting?

    4. GPHemsley commented on May 18, 2019

      @GPHemsley
      GPHemsleymannequin
      on May 18, 2019
      MannequinAuthor

      I've created a PR that fixes the issue, which I discovered while evaluating the test coverage for _strptime.

      Certain scenarios of error messages were never being hit because the cascade was out of order, and the tests were not showing that because they were throwing a different ValueError than the one they were expecting to throw.

    5. pganssle commented on May 18, 2019

      @pganssle
      pganssle
      on May 18, 2019
      Member

      Hm, I was a bit confused by your wording here, because I am able to trigger all the errors just fine even before this PR, but I do think that even though this isn't necessarily fixing inaccurate error messages (all the error messages *are* accurate), you're right that the text of the messages does seem to indicate that the original authors intended a cascade ordering more like the one you've proposed.

      I'll give this a more thorough review a bit later, thanks for working on this!

    6. GPHemsley commented on May 19, 2019

      @GPHemsley
      GPHemsleymannequin
      on May 19, 2019
      MannequinAuthor

      Ah yes, to be clear, I wasn't trying to suggest that the error messages themselves were wrong—just that they weren't triggering when the tests were expecting them to.

      Some of the existing tests currently trigger the "unconverted data remains" ValueError from earlier in the method, but because the messages are not checked, that is not immediately obvious. I've also added new tests for additional scenarios that would presumably also be considered invalid, based on the existing ones.

    7. ezio-melotti
      transferred this issue fromon Apr 10, 2022
    8. serhiy-storchaka
      added this to Date and time issues 🕰️on May 21, 2022

    9. serhiy-storchaka commented on Dec 26, 2023

      @serhiy-storchaka
      serhiy-storchaka
      on Dec 26, 2023
      Member

      There are two changes in test results:

      _strptime('1999 256', '%G %j'):
      was "ISO year directive '%G' must be used with the ISO week directive '%V' and a weekday directive ('%A', '%a', '%w', or '%u')."
      proposed "Day of the year directive '%j' is not compatible with ISO year directive '%G'. Use '%Y' instead."

      _strptime('50 5', '%V %u'):
      was "ISO week directive '%V' is incompatible with the year directive '%Y'. Use the ISO year '%G' instead."
      proposed "ISO week directive '%V' must be used with the ISO year directive '%G' and a weekday directive ('%A', '%a', '%w', or '%u')."

      In both cases the former message refers to a directive that does not appear in the format string.

    10. serhiy-storchaka
      added
      type-bugAn unexpected behavior, bug, or error
      3.11only security fixes
      3.12only security fixes
      3.13only security fixes
      and removed
      3.8 (EOL)end of life
      testsTests in the Lib/test dir
      on Dec 26, 2023

    11. serhiy-storchaka commented on Dec 26, 2023

      @serhiy-storchaka
      serhiy-storchaka
      on Dec 26, 2023
      Member

      I consider this as a bug.

    12. serhiy-storchaka
      closed this as completedon Dec 26, 2023
    13. github-project-automation
      moved this to Done in Date and time issues 🕰️on Dec 26, 2023

    14. serhiy-storchaka commented on Dec 26, 2023

      @serhiy-storchaka
      serhiy-storchaka
      on Dec 26, 2023
      Member

      Thank you for your contribution @GPHemsley. Sorry for the delay.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      3.11only security fixes3.12only security fixes3.13only security fixesstdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

      Projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions