Missing position-only markers for function parameters #95034

Activity

1. slateny

   added

   docsDocumentation in the Doc dirDocumentation in the Doc dir

   on Jul 20, 2022
2. slateny commented on Oct 12, 2022

   

   slateny

   on Oct 12, 2022

   ContributorAuthor

   More actions

   As there's quite a number of modules involved I'm wondering how best to structure PRs so it'd be easy to review, and have something like this in mind:

   1. Provide some command to get all modified functions (git diff ...)
   2. Copy-pastable list of functions with keyword arguments that can be run (all functions should raise TypeError) to confirm that the functions are indeed keyword-only, i.e.

   import math
   math.ceil(x=None)
   math.comb(n=None, k=None)
   math.copysign(x=None, y=None)
   math.fabs(x=None)
   

   results in

   >>> math.ceil(x=None)
   Traceback (most recent call last):
     File "<stdin>", line 1, in <module>
   TypeError: math.ceil() takes no keyword arguments
   >>> math.comb(n=None, k=None)
   Traceback (most recent call last):
     File "<stdin>", line 1, in <module>
   TypeError: math.comb() takes no keyword arguments
   >>> math.copysign(x=None, y=None)
   Traceback (most recent call last):
     File "<stdin>", line 1, in <module>
   TypeError: math.copysign() takes no keyword arguments
   >>> math.fabs(x=None)
   Traceback (most recent call last):
     File "<stdin>", line 1, in <module>
   TypeError: math.fabs() takes no keyword arguments
   

   confirming the fact that these functions are missing the position-only marker.

   3. Some diff command that can compare the two lists to confirm they're equivalent

   Any more suggestions to make it easier to review / show correctness?
3. slateny

   self-assigned this

   on Oct 12, 2022
4. slateny

   closed this as not plannedon Oct 21, 2022