asyncio exception handler called with incorrect context

Reproducer:

import asyncio
import contextvars

name = contextvars.ContextVar('name', default='foo')


def exc_handler(*args):
    assert name.get() == 'bar'


async def task():
    name.set('bar')
    1/0


async def main():
    loop = asyncio.get_running_loop()
    loop.set_exception_handler(exc_handler)
    asyncio.create_task(task())

asyncio.run(main())

On main:

Unhandled error in exception handler
context: {'message': 'Task exception was never retrieved', 'exception': ZeroDivisionError('division by zero'), 'future': <Task finished name='Task-2' coro=<task() done, defined at /workspaces/cpython/main.py:11> exception=ZeroDivisionError('division by zero')>}
Traceback (most recent call last):
  File "/workspaces/cpython/Lib/asyncio/base_events.py", line 1797, in call_exception_handler
    self._exception_handler(self, context)
  File "/workspaces/cpython/main.py", line 8, in exc_handler
    assert name.get() == 'bar'
AssertionError

The exception handler is called with incorrect context hence the AssertionError. It should called with the same context as the task.
My use case is retrieving the current request id from the context var if there are any unhandled error but because of this bug, I always get the default value.

Maybe you can retrieve the task from the dict arg to the handler and use its ‘_context’ attribute? Or maybe we need to add a ‘get_context()’ method to Task? That’s a complex API change b/c custom task implementations though. Otherwise the implementation seems far from easy, given how many places call this?

I only care about correct context in the task finalizer so that exception handler is called with correct context. I don't want to rely on any private attribute and it can change.

pythonGH-96704: Add task.get_context(), use it in call_exception_hand…

Your wish is my command. :-) (Sorry if you had a PR already, if you did we can compare notes, if you didn't you can review mine. :-)

pythonGH-96704: Add task.get_context(), use it in call_exception_hand…

GH-96704: Add {Task,Handle}.get_context(), use it in call_exception_h…

Merge branch 'main' into dictwatch

pythonGH-96704: Add {Task,Handle}.get_context(), use it in call_excep…

Navigation Menu

Repository navigation

asyncio exception handler called with incorrect context #96704

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

asyncio exception handler called with incorrect context #96704

Description

Activity

gvanrossum commented on Sep 10, 2022

kumaraditya303 commented on Sep 11, 2022

gvanrossum commented on Sep 11, 2022

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions