You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Document new 3.11 enum APIs (ReprEnum, global_* and/or show_flag_values) #98298
global_str, global_enum_repr and global_flag_repr were added (to replace the __str__() and __repr__() of the appropriate classes) and are not marked as private (_) and are exported by __all__, but aren't documented either. Should they be?
show_flag_values was added and is not in __all__, but its use is referred to in an error message (cited in the docs) and it is not marked private (_). Should this be documented as well?
@ethanfurman your guidance here would be much appreciated, thanks. I'm happy to review/copyedit a PR, or if you prefer, I can draft something and you review it. Ideally, we should get this in before the 3.11 release in a week or so...
Activity
ethanfurman commentedon Oct 19, 2022
Working on something now. I presume I commit to main and backport to 3.11?
CAM-Gerlach commentedon Oct 19, 2022
Yup 👍 Thanks!
gh-98298: [Enum] document ReprEnum, global_enum, and show_flag_values (…
pythongh-98298: [Enum] document ReprEnum, global_enum, and show_flag_…
gh-98298: [Enum] document ReprEnum, global_enum, and show_flag_values (…
CAM-Gerlach commentedon Oct 21, 2022
Hey @ethanfurman , are we all done here?
ethanfurman commentedon Oct 21, 2022
@CAM-Gerlach I tihnk so.
Bktero commentedon Jan 12, 2023
Hi!
Inthe documentation, we can read (3.11.1) :
It is not said that members of the enum are also added to the global namespace. Example:
Is this behavior a bug? Or is there something missing in the documentation?
ethanfurman commentedon Jan 12, 2023
The behavior is intended, the docs need updating.
Bktero commentedon Jan 13, 2023
I have been testing the almost all the new
enumfeatures yesterday, and I have other points for improving the documentation.Should I create a new issue or is there an existing issue I can contribute to? EDIT: this current issue is not closed, so I can add stuff here, right?
ethanfurman commentedon Jan 13, 2023
Yes, you can link PRs to this issue. Thanks!
gh-98298, gh-74730: [Enum] update docs (GH-103163)
pythongh-98298, pythongh-74730: [Enum] update docs (pythonGH-103163)
gh-98298, gh-74730: [Enum] update docs (GH-103163)
ethanfurman commentedon Apr 3, 2023
@Bktero Closing this issue. When you have more doc updates, please open a new issue. 😄
pythongh-98298, pythongh-74730: [Enum] update docs (pythonGH-103163)
pythongh-98298, pythongh-74730: [Enum] update docs (pythonGH-103163)