Repository navigation
--with-system-libmpdec / --with-system-expat still uses the vendored headers #98707
Description
Activity
Bisecting with only Modules/_decimal/libmpdec removed, because I got some other failures with removed Modules/expat on the way.
EDIT: Apparently, that's what you get when you spell expat as expact.
I am really really bad at autotools, but my best guess is that this is caused by:
Line 2584 in de69816
As LIBEXPAT_HEADERS contains a list that starts with Modules/expat/ascii.h.
Line 2589 in de69816
As LIBMPDEC_HEADERS contains a list that starts with Modules/_decimal/libmpdec/basearith.h.
In both cases, the dependency needs to be made conditional on the relevant --with-system-xxx option.
Testing a possible fix.
- changed the title
[-]--with-system-libmpdec / --with-system-expact still uses the vendored headers[/-][+]--with-system-libmpdec / --with-system-expat still uses the vendored headers[/+]on Oct 26, 2022 FTR this was a problem on older Pythons as well, but it was not exposed. #94474 did not introduce it, but it exposed it. Another problem this will most likely fix is:
--- STDERR --- /tmp/tmpt5xmo3n_/cpython/Objects/obmalloc.c:1449:1: warning: ‘always_inline’ function might not be inlinable [-Wattributes] 1449 | arena_map_get(block *p, int create) | ^~~~~~~~~~~~~ make: *** No rule to make target '/tmp/tmpt5xmo3n_/cpython/Modules/_decimal/libmpdec/basearith.c', needed by 'Modules/_decimal/libmpdec/basearith.o'. Stop. make: *** Waiting for unfinished jobs.... ---- END ---- ERROR ====================================================================== ERROR: test_freeze_simple_script (test.test_tools.test_freeze.TestFreeze.test_freeze_simple_script) ---------------------------------------------------------------------- Traceback (most recent call last): File "/builddir/build/BUILD/Python-3.11.0/Lib/test/test_tools/test_freeze.py", line 27, in test_freeze_simple_script outdir, scriptfile, python = helper.prepare(script, outdir) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/builddir/build/BUILD/Python-3.11.0/Tools/freeze/test/freeze.py", line 159, in prepare _run_quiet([MAKE, '-C', builddir, '-j8']) File "/builddir/build/BUILD/Python-3.11.0/Tools/freeze/test/freeze.py", line 25, in _run_quiet return subprocess.run( ^^^^^^^^^^^^^^^ File "/builddir/build/BUILD/Python-3.11.0/Lib/subprocess.py", line 569, in run raise CalledProcessError(retcode, process.args, subprocess.CalledProcessError: Command '['/usr/bin/make', '-C', '/tmp/tmpt5xmo3n_/python-build', '-j8']' returned non-zero exit status 2. ---------------------------------------------------------------------- Ran 1 test in 70.677s FAILED (errors=1)EDIT: It does not fix it.
- added a commit that references this issue
on Nov 13, 2022
Bug report
Python 3.12.0a1 or the main branch. Run:
This works fine with Python 3.11.0. I suspect somewhere along #94474 or a similar change, this has changed behavior, but I have not tried bisecting yet.
Your environment