Skip to content

gh-119664: Remove deprecated co_lnotab - #119665

Closed
picnixz wants to merge 2 commits into
python:mainfrom
picnixz:remove-deprecated-co_lnotab
Closed

picnixz wants to merge 2 commits into
python:mainfrom
picnixz:remove-deprecated-co_lnotab

Conversation

@picnixz

@picnixz picnixz commented May 28, 2024 •

Copy link
Copy Markdown
Member

This removes the deprecated code.co_lnotab attribute.

I am opening a (perhaps incomplete) PR because there are some things I am unusure of, such as:

  • is it correct to entirely remove the block in clinic.test.c?
  • there are some places where lnotab is referred so I changed them; should it be addressed separately?
  • should we keep the PyCode_Optimize function?

I know that the doc and the news are not yet updated because I am waiting for feedback.

@picnixz
picnixz marked this pull request as ready for review May 28, 2024 15:34
@hugovk hugovk changed the title [3.14] gh-119664: remove deprecated co_lnotab gh-119664: Remove deprecated co_lnotab May 28, 2024

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs more discussion. See my comment on the issue.

@bedevere-app

bedevere-app Bot commented May 29, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@picnixz
picnixz marked this pull request as draft May 29, 2024 10:23
@picnixz

picnixz commented May 29, 2024

Copy link
Copy Markdown
Member Author

Sure! I'll mark the PR as a draft to avoid possible noise for now.

@picnixz

picnixz commented Jun 19, 2024

Copy link
Copy Markdown
Member Author

Since it was decided not to do the removal now, I'm closing the PR.

@picnixz picnixz closed this Jun 19, 2024
@picnixz
picnixz deleted the remove-deprecated-co_lnotab branch June 19, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants