Repository navigation
Conversation
co_lnotabco_lnotab
iritkatriel
left a comment
There was a problem hiding this comment.
I think this needs more discussion. See my comment on the issue.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Sure! I'll mark the PR as a draft to avoid possible noise for now. |
|
Since it was decided not to do the removal now, I'm closing the PR. |
This removes the deprecated
code.co_lnotabattribute.I am opening a (perhaps incomplete) PR because there are some things I am unusure of, such as:
lnotabis referred so I changed them; should it be addressed separately?PyCode_Optimizefunction?I know that the doc and the news are not yet updated because I am waiting for feedback.
code.co_lnotab#119664