Repository navigation
Conversation
|
All commit authors signed the Contributor License Agreement. |
picnixz
left a comment
There was a problem hiding this comment.
I don't understand why the splitting algorithm got changed as well and why some tests were removed.
|
|
||
| @unittest.skipIf(MISSING_C_DOCSTRINGS, | ||
| "Signature information for builtins requires docstrings") | ||
| def test_multiline_docstring(self): |
There was a problem hiding this comment.
In the old tests, the first blank line was used as a separator, and the text after the first blank line was not displayed. However, now that I use the "ScrolledText" widget to display the document. So it is easy to show very long text, so I'm not limit the display to the content before the first blank line.
Do you have any suggestions? Do I need to keep this feature unchanged?
There was a problem hiding this comment.
So, to say:
- Before we only showed partial signature.
- Now we can show the full signature. So old tests are no more needed.
I would advise to keep tests that check whether multiline signatures from builtins are also correctly shown
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. @picnixz Thanks. |
|
Thanks for making the requested changes! @picnixz: please review the changes made to this pull request. |
…e.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
@picnixz Thanks for your advices. I have made the requested changes; please review again. |
|
Thanks for making the requested changes! : please review the changes made to this pull request. |
|
@picnixz Excuse me, how long it usually takes for the core review of this PR? or is there anything else I need to prepare? |
|
It depends; it can usually take months before merging a PR. I don't have much time for reviews.New features PRs are usually taken care of before the last alpha and last alpha for 3.15 would be in May. I have other more pressing matters that I need to address this w-e.
Why not create another branch? |
|
@terryjreedy Could you review this one please if you have enough time? |
@picnixz I’m currently learning the GitHub PR submission workflow and I’m not very proficient with the basic operations. It seems that I can submit multiple PRs via multiple branches, but when I forked the repository, I forgot to create a new branch, I made my commits directly on the "main" branch. If I sync with the upstream repository, it will update this PR and then trigger a new round of CI/CD, right? Maybe I should have created a "dev" branch first before starting development and submitting a PR. However, I messed up the initial steps and have no idea how to exchange it. I’ll try the right way when I submit another PR next time. |
|
This PR is stale because it has been open for 30 days with no activity. |
Issue: #94520
The text display widget in the "CalltipWindow" has been changed from "tk.Label" to "ScrolledText", and now the text in the "Calltip" window can be selected with mouse.
The display size of the "CalltipWindow" is set to the smaller value between the size when using the "tk.Label" widget and the default size of "tk.Text".
When the displayed text exceeds the display area of the "ScrolledText" window, showing the vertical scrollbar; otherwise, hiding the scrollbar.
Since more text can be displayed, "argspec" is no longer truncated, and the tests related to the max lines or text truncation have been removed from the unit tests.
I'm sorry for the long delay due to moving house, many data on my computer was lost, it tooks me a very long time to reorganize. But now we can restart.