Skip to content

gh-158886: Add INCREF/DECREF macros to stable_abi.toml - #158941

Merged
encukou merged 6 commits into
python:mainfrom
vstinner:stable_ref_macros
Oct 8, 2026
Merged

encukou merged 6 commits into
python:mainfrom
vstinner:stable_ref_macros

Conversation

@vstinner

@vstinner vstinner commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

@read-the-docs-community

read-the-docs-community Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #34984221 | 📁 Comparing 953d7e2 against main (1818fba)

  🔍 Preview build  

5 files changed · ± 5 modified

± Modified

@vstinner

vstinner commented Oct 6, 2026

Copy link
Copy Markdown
Member Author

@encukou: Ok, here is a small PR only adding 7 macros.

Comment thread Misc/stable_abi.toml
@encukou

encukou commented Oct 7, 2026

Copy link
Copy Markdown
Member

Thanks for getting to this. I spent some time thinking about this but kept getting lost in rabbit-holes. Let's do this step first :)

There's a few changes I'd like to make here. I sent them as vstinner#20.
If you'd like me to push directly here and let you review, let me know.

* distinguish between 'const' and 'macro' in stable_abi.dat

The file now has the 'kind' from the toml, not the ReST role.

* Fix kind of PY_VECTORCALL_ARGUMENTS_OFFSET

* Regenerate stable_abi.dat

* Make it explicit that macros aren't part of the ABI

* Move is_static_inline_function (per-item data) to the TOML file

* Appease linter rule, despite PEP 8
@vstinner

vstinner commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

There's a few changes I'd like to make here. I sent them as vstinner#20.

Thanks, I merged your PR.

If you'd like me to push directly here and let you review, let me know.

If I can chose, I prefer that you create a PR on my branch, as you did.

@encukou
encukou merged commit 20cb7fc into python:main Oct 8, 2026
51 of 52 checks passed
@encukou encukou added needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Oct 8, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @vstinner for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @vstinner for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@encukou

encukou commented Oct 8, 2026

Copy link
Copy Markdown
Member

Thank you!

@miss-islington-app

Copy link
Copy Markdown

Sorry, @vstinner and @encukou, I could not cleanly backport this to 3.14 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker 20cb7fc7077c20f4595fa65031f7047700a7bab3 3.14

@miss-islington-app

Copy link
Copy Markdown

Sorry, @vstinner and @encukou, I could not cleanly backport this to 3.15 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker 20cb7fc7077c20f4595fa65031f7047700a7bab3 3.15

@vstinner
vstinner deleted the stable_ref_macros branch October 8, 2026 12:17
@vstinner

vstinner commented Oct 8, 2026

Copy link
Copy Markdown
Member Author

I will backport this change to 3.14 and 3.15 when the 3.15 branch will be unblocked (next week).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants