Repository navigation
gh-85454: Remove distutils.ccompiler from Tools/c-analyzer - #95171
Conversation
| } | ||
|
|
||
|
|
||
| def _get_default_compiler(): |
There was a problem hiding this comment.
Minimalized ported version from
cpython/Lib/distutils/ccompiler.py
Lines 937 to 956 in f4c0348
There was a problem hiding this comment.
It may be worth having a short comment indicating this was derived from the distutils code.
|
|
||
|
|
||
| def _get_default_compiler(): | ||
| if re.match('cygwin.*', sys.platform) is not None: |
There was a problem hiding this comment.
You can just remove cygwin as it is unsupported.
There was a problem hiding this comment.
We have a bunch of Cygwin-related codes (__CYGWIN__) in CPython code base, Did we decide to remove them?
Even if PEP 11 defined tier-based platforms, I don't interpret them as removing all unsupported platform codes.
There was a problem hiding this comment.
Cygwin is certainly still alive to some extent, so I'd say let's not worry about that in the PR.
There was a problem hiding this comment.
If you remove cygwin branch, it will fallback to unix which is better than special casing it but it's minor and you can ignore this too.
There was a problem hiding this comment.
If you remove cygwin branch, it will fallback to unix which is better than special casing it but it's minor and you can ignore this too.
It's care about Windows/Cygwin case, see: https://docs.python.org/3/library/sys.html.
It can be gone to the wrong fallback logic.
Uh oh!
There was an error while loading. Please reload this page.