Skip to content

GH-96075: move interned dict under runtime state - #96077

Merged
miss-islington merged 4 commits into
python:mainfrom
kumaraditya303:interned
Aug 22, 2022
Merged

miss-islington merged 4 commits into
python:mainfrom
kumaraditya303:interned

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Aug 18, 2022 •

Copy link
Copy Markdown
Contributor

Automerge-Triggered-By: GH:ericsnowcurrently

@kumaraditya303 kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 18, 2022
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 415902a 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 18, 2022

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly LGTM

Comment thread Include/internal/pycore_global_objects.h Outdated
Comment thread Objects/unicodeobject.c Outdated
Comment thread Objects/unicodeobject.c Outdated
@bedevere-bot

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants