Skip to content

gh-97937: dis docs: add adaptive=False - #97939

Merged
JelleZijlstra merged 5 commits into
python:mainfrom
JelleZijlstra:adaptive
Oct 25, 2022
Merged

gh-97937: dis docs: add adaptive=False#97939
JelleZijlstra merged 5 commits into
python:mainfrom
JelleZijlstra:adaptive

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Oct 5, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Oct 5, 2022
@JelleZijlstra JelleZijlstra added the needs backport to 3.11 only security fixes label Oct 5, 2022
hauntsaninja
hauntsaninja reviewed Oct 6, 2022
View reviewed changes
Comment thread Doc/library/dis.rst Outdated
@JelleZijlstra @hauntsaninja
Update Doc/library/dis.rst
57697f1 
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
brandtbucher
brandtbucher approved these changes Oct 25, 2022
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Comment thread Doc/library/dis.rst Outdated
@JelleZijlstra @brandtbucher
Update Doc/library/dis.rst
b9eb5f6 
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
@JelleZijlstra JelleZijlstra self-assigned this Oct 25, 2022
@JelleZijlstra
JelleZijlstra merged commit 5d8bf2b into python:main Oct 25, 2022
@miss-islington

miss-islington commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

Sorry @JelleZijlstra, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 5d8bf2b106e694423bafaa3e1ea1edf20037573c 3.11

@JelleZijlstra
JelleZijlstra deleted the adaptive branch October 25, 2022 22:58
@JelleZijlstra JelleZijlstra added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Oct 25, 2022
@miss-islington

miss-islington commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Oct 25, 2022

Copy link
Copy Markdown

GH-98679 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 25, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 25, 2022
@JelleZijlstra @miss-islington
pythongh-97937: dis docs: add adaptive=False (pythonGH-97939)
9166fbe 
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
(cherry picked from commit 5d8bf2b)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
miss-islington added a commit that referenced this pull request Oct 25, 2022
@miss-islington @JelleZijlstra
gh-97937: dis docs: add adaptive=False (GH-97939)
4fc042f 
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
(cherry picked from commit 5d8bf2b)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja left review comments
@brandtbucher brandtbucher brandtbucher approved these changes

Assignees

@JelleZijlstra JelleZijlstra

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JelleZijlstra @miss-islington @bedevere-bot @hauntsaninja @brandtbucher