Repository navigation
Possible bug introduced with PR250, joinpath with "." causes StopIteration #263
Description
Consider the following code snippet:
stopiteration_bug.py:
import spacem_maldi.Ontologies
from importlib_resources import files
print(files(spacem_maldi.Ontologies) / ".")With importlib-resources<=5.7.1 this produces the following output:
/home/hilsenst/GitlabEMBL/spacem-ht/src/spacem-maldi/spacem_maldi/Ontologies
Starting from version 5.8.0, i.e. after PR #250 this throws a StopIteration exception:
~/Untracked$ python stopiteration_bug.py
Traceback (most recent call last):
File "stopiteration_bug.py", line 5, in <module>
print(files(spacem_maldi.Ontologies) / ".")
File "/home/hilsenst/miniconda3/envs/spacem-maldi-control/lib/python3.8/site-packages/importlib_resources/abc.py", line 130, in __truediv__
return self.joinpath(child)
File "/home/hilsenst/miniconda3/envs/spacem-maldi-control/lib/python3.8/site-packages/importlib_resources/readers.py", line 87, in joinpath
return super().joinpath(*descendants)
File "/home/hilsenst/miniconda3/envs/spacem-maldi-control/lib/python3.8/site-packages/importlib_resources/abc.py", line 114, in joinpath
target = next(names)
StopIteration
The spacem_maldi package is a private package, but I don't think that is relevant here. If needed I can try and create a minimal public package.
Activity
jordan-wirth commentedon Aug 31, 2022
+1, there should be a way to get the Pathlib Path without joinpath anyways.
Also, a workaround for now:
print((files(spacem_maldi.Ontologies) / "fakefilename.txt").parent)VolkerH commentedon Sep 1, 2022
Yes, I felt that
/ "."was a crutch to start with but couln't find a better (proper) way.jaraco commentedon Oct 5, 2022
Oh, you shouldn't rely on
joinpathto get a materialized path. If what you need is a materialized path on the file system, useas_file(traversable).files()returns a Traversable andTraversable.joinpathalso returns a Traversable, which may or may not be on the filesystem. Although depending on your usage, you may not need to materialize the traversable at all and you may be able to get the value directly from the Traversable (such as with.openor.read_text()).Still, you shouldn't get a
StopIterationby attempting to join a path.jaraco commentedon Oct 5, 2022
I'm unable to replicate the issue:
What's special about
spacem_maldi.Ontologiesthat triggers the issue?jaraco commentedon Oct 5, 2022
I thought maybe the issue was that
Ontologieswas a directory without an__init__, but I'm still unable to trigger the failure:jaraco commentedon Dec 4, 2022
Since the issue isn't reproducible, I'm closing it, but feel free to follow-up with the requested info and we can investigate further.