Conversation
PEP 673 only allows Self in annotations within a class definition. Type variable bounds were not checked, so an in-class legacy TypeVar(bound=Self) or a PEP 695 method-level [T: Self] was silently accepted. Fixes python#21960
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Author
|
Closing in favor of #21967, which predates this PR by three weeks and is from the issue reporter. My apologies for the duplicate — I located it only after opening this one; searching by the issue's keywords missed it because the PR title is phrased differently. I'm leaving a couple of implementation notes from my own pass on #21967 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21960
Rejects
Selfused as the bound of a type parameter, in both PEP 695 syntax and legacyTypeVar(bound=...)declarations, by reusing the existingprohibit_self_typemechanism in semantic analysis:analyze_type_paramnow analyzes a PEP 695 upper bound withprohibit_self_type="a type variable bound". Class-level bounds previously hit the existing "only allowed in annotations within class definition" check; they now get the more precise new message.bound=path passes the same context throughget_typevarlike_argumentandexpr_to_analyzed_type(new pass-through parameters), soTypeVar("T", bound=Self)inside a class body is also rejected. Module-level use was already rejected.Notes:
TypeVar("T", Self, int)) and PEP 695 defaults are left unchanged — out of scope for this issue, can follow up if maintainers want those rejected too.New cases are in
testTypingSelfInvalidAsTypeParameterBound(check-selftype.test), covering in-class method-level and class-level PEP 695 bounds plus the legacy form.