Skip to content

PEP 845: Update discussions-to and post-history links - #5165

Open
cdce8p wants to merge 3 commits into
python:mainfrom
cdce8p:pep845-update-links
Open

cdce8p wants to merge 3 commits into
python:mainfrom
cdce8p:pep845-update-links

Conversation

@cdce8p

@cdce8p cdce8p commented Oct 9, 2026

Copy link
Copy Markdown
Contributor
  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

New thread, created for more exposure:
https://discuss.python.org/t/pep-845-leading-dot-value-patterns-for-match-statement/109405

/CC @tmke8

@cdce8p
cdce8p requested a review from ethanfurman as a code owner October 9, 2026 21:02
Comment thread peps/pep-0845.rst Outdated
@read-the-docs-community

read-the-docs-community Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 pep-previews | 🛠️ Build #35050726 | 📁 Comparing 1d130ea against latest (545c670)

  🔍 Preview build  

4 files changed
± pep-0384/index.html
± pep-0489/index.html
± pep-0652/index.html
± pep-0845/index.html

Co-authored-by: Stan Ulbrych <stan@python.org>
@tmke8

tmke8 commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

I still wonder whether the pre-PEP discussion should also be linked: https://discuss.python.org/t/pattern-matching-on-constants-that-arent-in-a-namespace-especially-sentinels/107916 . Is there a policy on that? I think that thread is still relevant because the main issue with this PEP is not the semantics but the spelling/syntax. And that thread was full of syntax discussion.

@cdce8p

cdce8p commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

I still wonder whether the pre-PEP discussion should also be linked: https://discuss.python.org/t/pattern-matching-on-constants-that-arent-in-a-namespace-especially-sentinels/107916 .

I was thinking about this, too. Pushed a new commit.

Comment thread peps/pep-0845.rst
@@ -1,14 +1,16 @@
PEP: 845
Title: Leading-Dot Value Patterns

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the new Discourse thread has a slightly more detailed title, which I personally find a little clearer. Maybe consider using it here as well?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't be opposed to update the title. However, maybe this would be better done in a separate PR? From what I've read in the (new) thread, the abstract could be improved a bit as well.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think the title of the discourse thread is better.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is quite compact, so adding it here would be fine, but you can also do it separately.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just update the links here then and do everything else in a separate PR.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants