Skip to content

Use Protocols to annotate python3 <= 3.6 compileall argument #3480

Closed
Closed
Use Protocols to annotate python3 <= 3.6 compileall argument#3480

Description

@SKalt
SKalt
opened on Nov 23, 2019

in stdib/3/compileall.pyi, there's a comment

# rx can be any object with a 'search' method; once we have Protocols we can change the type.

Since we have Protocols, we can do this.

history The comment was introduced on Mar 18, 2017 by @JelleZijlstra in commit efdf2f1, and came up in the review of #3476.

Activity

  1. JelleZijlstra commented on Jan 31, 2022

    @JelleZijlstra
    JelleZijlstra
    on Jan 31, 2022
    Member

    Looks like #5172 fixed this

  2. JelleZijlstra
    closed this as completedon Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions