Skip to content

Let ctypes._CData.from_buffer[_copy] accept any buffer object - #2610

Merged
JelleZijlstra merged 1 commit into
python:masterfrom
dgelessus:fix_ctypes_from_buffer
Nov 20, 2018
Merged

JelleZijlstra merged 1 commit into
python:masterfrom
dgelessus:fix_ctypes_from_buffer

Conversation

@dgelessus

Copy link
Copy Markdown
Contributor

Fixes the issue discussed here: #1906 (comment)

@srittau

srittau commented Nov 20, 2018

Copy link
Copy Markdown
Collaborator

Relevant: python/typing#593.

@JelleZijlstra

Copy link
Copy Markdown
Member

This seems OK for now; we may have to tweak it if/when we add buffer support to typing.

@JelleZijlstra
JelleZijlstra merged commit 45d4e88 into python:master Nov 20, 2018
yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this pull request Jan 23, 2019
hauntsaninja pushed a commit to hauntsaninja/typeshed that referenced this pull request Jan 30, 2020
Follows the approach in python#2610
hauntsaninja pushed a commit to hauntsaninja/typeshed that referenced this pull request Feb 5, 2020
Follows the approach in python#2610
JelleZijlstra pushed a commit that referenced this pull request Feb 22, 2020
* fcntl: mark positional-only args

* fcntl: use overload for fcntl.fcntl

The comment about depending on the type of arg seems incorrect
bf50135

I checked the docs and examples, CPython implementation and CPython tests, but
I might be missing something

* fcntl: use overload for fcntl.ioctl

Based off of docs and examples

* fcntl: type buffers better

Follows the approach in #2610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants