Repository navigation
Improve stubs for __pow__ - #6287
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: freqtrade (https://github.com/freqtrade/freqtrade.git)
+ freqtrade/templates/sample_hyperopt_loss.py:47: error: Argument 1 to "exp" has incompatible type "complex"; expected "Union[SupportsFloat, SupportsIndex]"
+ freqtrade/optimize/hyperopt_loss_short_trade_dur.py:48: error: Argument 1 to "exp" has incompatible type "complex"; expected "Union[SupportsFloat, SupportsIndex]"
pandas (https://github.com/pandas-dev/pandas.git)
+ pandas/io/stata.py:2990: error: Incompatible return value type (got "float", expected "int") [return-value]
vision (https://github.com/pytorch/vision.git)
+ torchvision/models/detection/backbone_utils.py:133: error: Argument 3 to "BackboneWithFPN" has incompatible type "List[float]"; expected "List[int]" [arg-type]
aiortc (https://github.com/aiortc/aiortc)
+ src/aiortc/rate.py:158: error: Incompatible types in assignment (expression has type "Union[float, complex]", variable has type "float")
+ src/aiortc/rate.py:440: error: Incompatible types in assignment (expression has type "complex", variable has type "float")
+ src/aiortc/rate.py:442: error: Incompatible types in assignment (expression has type "complex", variable has type "float")
prefect (https://github.com/PrefectHQ/prefect.git)
+ src/prefect/utilities/datetimes.py:51: error: Incompatible return value type (got "Union[timedelta, float]", expected "timedelta")
+ src/prefect/utilities/datetimes.py:51: error: Unsupported operand types for * ("None" and "float")
+ src/prefect/utilities/datetimes.py:51: note: Left operand is of type "Optional[timedelta]"
kornia (https://github.com/kornia/kornia.git)
+ kornia/geometry/transform/pyramid.py:203: error: Argument 1 to "sqrt" has incompatible type "complex"; expected "Union[SupportsFloat, SupportsIndex]" [arg-type]
paasta (https://github.com/yelp/paasta.git)
+ paasta_tools/utils.py:3553: error: Incompatible return value type (got "float", expected "int")
rich (https://github.com/willmcgugan/rich.git)
+ rich/filesize.py:50: error: Incompatible return value type (got "Tuple[float, str]", expected "Tuple[int, str]")
sympy (https://github.com/sympy/sympy.git)
+ sympy/core/evalf.py:300: error: Incompatible types in assignment (expression has type "float", variable has type "int")
+ sympy/core/evalf.py:623: error: Incompatible types in assignment (expression has type "float", variable has type "int")
+ sympy/core/evalf.py:1196: error: Incompatible types in assignment (expression has type "float", variable has type "int")
+ sympy/core/evalf.py:1354: error: Incompatible types in assignment (expression has type "float", variable has type "Symbol")
|
Member
Author
Hmm, it's annoying that the type system doesn't have a way of specifying a positive integer. The new |
AlexWaygood
marked this pull request as draft
November 12, 2021 19:33
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Akuli
reviewed
Nov 12, 2021
| def __sub__(self, __x: complex) -> complex: ... | ||
| def __mul__(self, __x: complex) -> complex: ... | ||
| def __pow__(self, __x: complex, mod: None = ...) -> complex: ... | ||
| def __pow__(self, __x: complex | int | float, mod: None = ...) -> complex: ... |
Collaborator
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AlexWaygood
marked this pull request as ready for review
November 12, 2021 20:14
| def pow(base: float, exp: int, mod: None = ...) -> float: ... | ||
| @overload | ||
| def pow(base: float, exp: float, mod: None = ...) -> Any: ... # return type could be float or complex | ||
| def pow(base: float, exp: float, mod: None = ...) -> Any: ... # return type could be float or complex depending on x |
Collaborator
There was a problem hiding this comment.
It also depends on base. If the base is positive, then any power will also be positive. Complex numbers need a negative base and a negative power.
Maybe the whole "depending on" part should be deleted? It obviously depends on the arguments in some way, which is really all that needs to be said.
Collaborator
There was a problem hiding this comment.
It's worth spelling out the conditions... pow is like catnip for typeshed contributors, because everyone always starts off thinking only about positive integers :-)
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Collaborator
|
Hooray! |
ikamensh
reviewed
Nov 16, 2021
| def __rdivmod__(self, __x: int) -> tuple[int, int]: ... | ||
| @overload | ||
| def __pow__(self, __x: Literal[2], __modulo: int | None = ...) -> int: ... | ||
| def __pow__(self, __x: int, __modulo: Literal[0]) -> NoReturn: ... |
Member
There was a problem hiding this comment.
This is pow(1, 1, 0):
In [4]: pow(1, 1, 0)
Traceback (most recent call last):
File "/main_instance_shell/jelle/venv/lib/python3.6/site-packages/IPython/core/interactiveshell.py", line 3343, in run_code
exec(code_obj, self.user_global_ns, self.user_ns)
File "<ipython-input-4-23a0b67588cd>", line 1, in <module>
pow(1, 1, 0)
ValueError: pow() 3rd argument cannot be 0
7 of 22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.