Repository navigation
Add regression tests for builtins.pow and object.__reduce__ - #7663
Conversation
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
JelleZijlstra
left a comment
There was a problem hiding this comment.
Thanks for setting this up! It's going to be very helpful. I'll send PRs later for my zip_longest cases from the other day.
| 100% test coverage for typeshed is neither necessary nor desirable, as it would | ||
| lead to unnecessary code duplication. Moreover, typeshed has multiple other | ||
| mechanisms for spotting errors in the stubs. As such, this directory should | ||
| only contain tests for functions and classes which are known to have caused | ||
| problems in the past, where the stubs are difficult to get right. |
There was a problem hiding this comment.
While this is correct, it might need a tl;dr in bold. As discussed, it's difficult to convince some people that they don't need to write tests.
| "stdlib", | ||
| "stubs" | ||
| "stubs", | ||
| "test_cases" |
There was a problem hiding this comment.
- Do we really want this to be in both pyrightconfigs?
- Does mypy support
assert_type()yet? If it does, we could instead pointmypy_primerat typeshed'stest_cases. That way we would know if a PR to mypy breaks the tests.
There was a problem hiding this comment.
- I don't really understand how the two pyrightconfigs work with each other
¯\_(ツ)_/¯. Happy to have it in only one if that's better. - No, mypy doesn't support
assert_typeyet. The PR was recently merged, and might make it into 0.950, but also might not. See Release 0.950 planning mypy#12579 (comment)
There was a problem hiding this comment.
Mypy supports assert_type() on master (I added it last week). I am hoping to convince Jukka to put it in the upcoming 0.950 release. We should make mypy run on this directory too as soon as 0.950 is released, or use master if we're feeling brave.
There was a problem hiding this comment.
Update: assert_type has been cherry-picked onto the 0.950 branch, so we should be able to point mypy_primer at this directory as soon as 0.950 is released.
There was a problem hiding this comment.
Hopefully we can just run mypy regularly, no need to use mypy-primer.
|
Can we keep the comments in builtins? This is a super common point of clarification and there is value in having the stubs be self-documenting. Another suggestion could be to move this under |
Done (78b9dd0).
To me, it doesn't really feel like this stuff "fits in" with the other content in
Yeah, the third-party stubs would complicate things. Perhaps we could cross that bridge when we come to it? |
This comment was marked as outdated.
This comment was marked as outdated.
| "stdlib", | ||
| "stubs" | ||
| "stubs", | ||
| "test_cases" |
There was a problem hiding this comment.
Hopefully we can just run mypy regularly, no need to use mypy-primer.
| This directory contains regression tests for the stubs found elsewhere in the | ||
| typeshed repo. Each file contains a number of test cases, all of which should | ||
| pass a type checker without error. |
There was a problem hiding this comment.
In the long term we should probably also allow test that fail a type checker to be able to test the negative case.
There was a problem hiding this comment.
Yup. Once we're running mypy on this directory, we can do that by # type: ignoring (with specific error codes) lines that we want to fail and running mypy with --warn-unused-ignores. We can't use that flag globally when running mypy on typeshed, but we should be able to use it for this directory.
As discussed in #1339 (comment) (among other places).
At the moment, this PR has only pyright running on the
test_casesdirectory. We can potentially add mypy once there's a mypy release that supportsassert_type.