Repository navigation
Disabling ignoring unused vars for _ prefix #1719
Description
Activity
- added this to the milestone
on Mar 5, 2017 Also, why do we have
vars: 'local'rather than the default'global'setting?I can submit a PR.
Though I am not sure about thevarssetting. Can't find a use case of having an unused global variable.If you could go through the git blame history for who added it and why, that could help. Or maybe there was no good reason at all.
The default setting in eslint was
localat the time Airbnb set their config. Eslint later changed the default toall(global) and I'm guessing Airbnb never updated.Edit: For context this is why it changed from
localtoallYea.
This setting certainly predates my involvement with the Airbnb config. I can't see any reason not to change it to "all" - can someone file an issue, or better, send a PR explaining the rationale?
Sure, I'll do it.
Reacted by Jordan Harband- locked and limited conversation to collaborators
on Jan 21, 2019
We currently ignore unused vars with
_prefix, mainly as a workaround for deleting extra properties in...restdestructuring. However #1705 is a proper fix for this, so I think we should remove the_rule in the next major bump. This would fix #1387.