Skip to content

UnhandledPromiseRejectionWarning on Node 7.7.2 #1776

Closed
Closed
UnhandledPromiseRejectionWarning on Node 7.7.2#1776
Labels
issue: bugtag: underlying tools
Milestone
0.9.5

Description

@cschroeter
cschroeter
opened on Mar 9, 2017

Description

Bug

Expected behavior

npm start

should not return a UnhandledPromiseRejectionWarning

Actual behavior

cschroeter@pc:~/workspace/my-first-react-app$ npm start

> test@0.1.0 start /home/cschroeter/workspace/my-first-react-app
> react-scripts start

(node:1863) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): TypeError: "listener" argument must be a function
(node:1863) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Environment

Run these commands in the project folder and fill in their results:

  1. npm ls react-scripts (if you haven’t ejected):
cschroeter@pc:~/workspace/my-first-react-app$ npm ls react-scripts
my-frist-react-app@0.1.0 /home/cschroeter/workspace/my-frist-react-app
└── react-scripts@0.9.4
  1. node -v:
v7.7.2
  1. npm -v:
4.3.0

Then, specify:

  1. Operating system:
    Windows 10 in Linux Bash Shell Build 15048 (Creator Update)

To Reproduce

$ create-react-app my-first-react-app
$ cd my-first-react-app
$ npm start

Activity

  1. whelmich commented on Mar 9, 2017

    @whelmich
    whelmich
    on Mar 9, 2017

    Can reproduce in Linux Mint 18.1 with the same node/npm versions.

    Problem can be resolved by downgrading node to 7.7.1 or older. The problem appeared after upgrading node to 7.7.2.

  2. whelmich commented on Mar 9, 2017

    @whelmich
    whelmich
    on Mar 9, 2017

    This problem seems to be caused by detect-port:1.0.1, used by react-scripts. It causes an error in detect-port/lib/detect-port.js on line 61 socket.connect(...).

    detect-port is currently at version 1.1.0 which features a different approach of port detection. This version resolves the error for node v7.7.2, and also works with 7.6.0 and 7.7.1.

    The Travis build test of version 1.1.0 of detect-port seems to fail, because the test is using node v4.8.0. On node 7.6.0, 7.7.1 and 7.7.2 the tests complete without any problems.

    As the minimum node version of react-scripts is >=4 I am not sure if upgrading the version of detect-port in package.json in react-scripts is an acceptable solution as detect-ports:1.1.0 only passes its test on node version >=6.

  3. Timer commented on Mar 9, 2017

    @Timer
    Timer
    on Mar 9, 2017
    Contributor

    We do not support Node 7, so the official recommendation would be to downgrade to the latest LTS.
    Currently, that is Node v6.10.0.

    However, we understand this might be desirable. Would one of you like to send a PR adding Node 7 to the CI (only one of the test cases) and resolving this issue?
    Thanks!

    /cc @whelmich

  4. Timer
    added
    tag: underlying tools
    on Mar 9, 2017
  5. Timer
    added this to the 0.9.5 milestone on Mar 9, 2017

  6. gaearon commented on Mar 9, 2017

    @gaearon
    gaearon
    on Mar 9, 2017
    Contributor

    (We definitely should support Node 7 tho)

  7. taivu commented on Mar 9, 2017

    @taivu
    taivu
    on Mar 9, 2017

    I get the same error in MacOS El Capitan and Ubuntu (both node 7). Weird thing is that in Ubuntu it still runs and starts the server, but doesnt detect any changes to files. In MacOS, it just quits.

  8. Timer commented on Mar 9, 2017

    @Timer
    Timer
    on Mar 9, 2017
    Contributor

    (We definitely should support Node 7 tho)

    We should probably run all test cases on Node 7 then. 🤷‍♀️

    Node 8 comes out in a month though, which I assume means we would drop Node 7 support. Worth waiting?

  9. gaearon commented on Mar 9, 2017

    @gaearon
    gaearon
    on Mar 9, 2017
    Contributor

    I don't think we should skip supported versions, it would be confusing.

  10. vhain commented on Mar 9, 2017

    @vhain
    vhain
    on Mar 9, 2017

    It can be bug of Node 7.7.2 and if it is, it should be fixed by nodejs/node#11762

    +i think that promise should be catch somewhere

  11. Timer commented on Mar 9, 2017

    @Timer
    Timer
    on Mar 9, 2017
    Contributor

    Ah, brilliant @vhain! This definitely looks like a regression then. 😄

  12. gaearon
    changed the title [-]UnhandledPromiseRejectionWarning in Windows 10[/-] [+]UnhandledPromiseRejectionWarning on Node 7.7.2[/+] on Mar 9, 2017
  13. gaearon
    added
    issue: bug
    on Mar 9, 2017

  14. whelmich commented on Mar 9, 2017

    @whelmich
    whelmich
    on Mar 9, 2017

    After upgrading detect-port in react-scripts to 1.1.0, I can run create-react-app without any issues on node 4.8.0, 6.10.0 and 7.7.2. So upgrading it could still be a solution, without impacting the minimal node version.

    Travis/tests failing on detect-port:1.1.0 with node <6 as mentioned earlier, seem to be related to its test dependency only. It doesn't withhold the package from working on node <6 when used with react-scripts. Though, I'm not sure if this may influence any other create-react-app tests somehow.

  15. gaearon commented on Mar 9, 2017

    @gaearon
    gaearon
    on Mar 9, 2017
    Contributor

    Want to send a PR enabling tests on Node 7 + bumping the version?

  16. 19 remaining items

  17. mnemanja commented on Mar 17, 2017

    @mnemanja
    mnemanja
    on Mar 17, 2017

    @gaearon
    Thanks,
    removing node_modules completely and installing all the dependencies fixed the issue for me.

    Thanks for the hint @Timer, I'll be sure to remember it next time something like this happens.

    Keep up the good work guys :)

  18. gaearon commented on Mar 17, 2017

    @gaearon
    gaearon
    on Mar 17, 2017
    Contributor

    Looks like we need to bump detect-port to 1.1.1: node-modules/detect-port#16 (comment)

    PR, anyone?

  19. Andreyco commented on Mar 20, 2017

    @Andreyco
    Andreyco
    on Mar 20, 2017
    Contributor

    cc @gaearon PR opened #1861
    Can confirm, detect-port picks next available port as expected.

  20. scottdixon-zz
    added a commit that references this issue on Apr 17, 2017

    Update react-scripts to 0.9.5

    f8da161
  21. sbuzonas
    added a commit that references this issue on May 5, 2017

    Run CI on Node 7; Bump detect-port: 1.0.1 -> 1.1.0 (react#1776) (reac…

    33721da
  22. randycoulman
    added a commit that references this issue on May 8, 2017

    Run CI on Node 7; Bump detect-port: 1.0.1 -> 1.1.0 (react#1776) (reac…

    6812822
  23. iamlacroix
    added a commit that references this issue on May 16, 2017

    Merge upstream changes from create-react-app 0.9.x (#84)

    7a11edd
  24. amira-s
    added a commit that references this issue on May 31, 2017

    [chore]: upgrade react-scripts to latest

    f66e92f
  25. iamlacroix
    added a commit that references this issue on Aug 2, 2017

    Merge upstream create-react-app v1.0.7 (#90)

    6f3e256

  26. taykcrane commented on Aug 21, 2017

    @taykcrane
    taykcrane
    on Aug 21, 2017

    For any newbies running into this bug, I fixed it by downgrading NPM to the LTS (latest stable version) of 6.11.2.

  27. davidcalhoun commented on Dec 19, 2017

    @davidcalhoun
    davidcalhoun
    on Dec 19, 2017

    Had a similar issue using npm to install. Fixed by removing both npm-modules and package-lock.json (a variant of @gaearon's comment above)

  28. shiziChing commented on Feb 7, 2018

    @shiziChing
    shiziChing
    on Feb 7, 2018

    说中文撒大佬们

  29. lock
    locked and limited conversation to collaborators on Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    issue: bugtag: underlying tools

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions