Repository navigation
Public Beta Testing of react-scripts@1.0.0 #2172
Description
Activity
Testing. Compilation failed. Something is wrong with webpack.
Will try to get more info.
What I've tried to solve
- run
yarn upgrade. This got me into:
Failed to compile. ./~/react-error-overlay/lib/utils/unmapper.js Module not found: Can't resolve '/Users/dan/p/create-react-app/packages/babel-preset-react-app/node_modules/babel-runtime/regenerator' in '/[---------]/my-project/node_modules/react-error-overlay/lib/utils'- removing
node_modulesandyarn.lockwith fresh install did not help either.
Reacted by Chris Johnson, Benjamin Giesinger, Kenneth Aasan and HUIKE- run
@rogovdm
Can you provide minimal project reproducing this?
@gaearon Please, notice
/dan/p/part in path. Something is clearly wrong. 😺Hmm yea that looks funny.
Reacted by Simon Mansfield, Kenneth Aasan, Philipp Kief and seungha-kimMaybe something in my local Lerna setup got messed up. I'll try to republish from another laptop in an hour or two.
Same problem:
Failed to compile. ./~/react-error-overlay/lib/utils/unmapper.js Module not found: Can't resolve '/Users/dan/p/create-react-app/packages/babel-preset-react-app/node_modules/babel-runtime/regenerator' in '/home/micooz/Projects/blinksocks-desktop/frontend/node_modules/react-error-overlay/lib/utils'Can you edit that file by hand for now to remove the absolute filename from it? Are there more such files?
@gaearon checked
node_modulesfor/Users/danpattern.31 results in 9 files
All of
.jsfiles are aboutregeneratormodule.Fixing path in
react-error-overlaydid the trick for meI can confirm that dan is lurking my on pc as well 📦
I changed the imports fromimport _regeneratorRuntime from '/Users/dan/p/create-react-app/packages/babel-preset-react-app/node_modules/babel-runtime/regenerator';to
import _regeneratorRuntime from '../../../babel-runtime/regenerator';seems to work now. start and build works
Same problem here. Fixed by renaming my user to Dan :)
No actually @jamesmcallister is right. It is in the mapper, unmapper and getSourceMap fileReacted by rohovdmytro, Stepan Kuzmin, Kai Hao, Chung Yen Li, James McAllister, Julien Barret, James Hegedus, Arne Wiese, JackChan, Philipp Kief and 5 more42 remaining items
I get get a new warning:
[eslint] Definition for rule 'jsx-a11y/alt-text' was not found (jsx-a11y/alt-text)I get this warning now too, and can't figure out how to get rid of it. It's not documented in the README, and Googling around for this didn't turn up anything useful.
Reacted by [ZE]Where do you get it? You have not specified your editor, plugin, whether you use global ESLint for it, etc.
I'll close this issue since 1.0 is out but please file new ones if something is confusing!
Nuclide, latest version (of Atom as well). No global eslint installed.
BTW, I found the plugin & its documentation. Fixed it with the following in my.eslintrc:"rules": { "jsx-a11y/alt-text": "off",That's not the right fix, you're still running wrong versions of plugins. This silences this warning but you'll see more breakage in the future. I suggest fixing the root cause rather than symptoms.
Let's try this:
- Ensure that in Atom ESLint settings you have "Use Global ESLint" turned off
- Run
npm installin your project (oryarn) - Quit Atom (ensure its process doesn't hang around)
- Start Atom again
I think that should help but let me know if not, and we can debug more.
Reacted by Sam HulickThat did the trick! I noticed that .eslintrc changes would get recognized by closing a file and reopening it, but in this case, quitting Atom entirely was required.
Yea. Since it loads rules into memory, their code sticks around in the require cache even after closing the file.
Hi gaearon & all, I'm getting the following flow error in both Nuclide and VS Code. I've tried the above steps you recommended several times but no joy. Also tried deleting node_modules and reinstalling.
identifier
ESLintContextCould not resolve name
Doesn't happen in React Scripts v0.9.x; only when upgrading to 1.0.2-3
In Nuclide 0.228.0:
- Linter is disabled
- linter-eslint 8.1.7 is enabled with use global off
In VS Code 1.12.2:
- ESLint is enabled
Here are my .eslintrc and .flowconfig settings:
devDependancies:
"devDependencies": { "@kadira/storybook": "^2.21.0", "eslint-plugin-jsx-a11y": "^5.0.3", "flow-bin": "^0.42.0", "react-scripts": "^1.0.3", "stylelint": "^7.10.1", "stylelint-config-standard": "^16.0.0" },Any suggestions much appreciated!
The error is because Flow is trying to typecheck the ESLint plugin.
You probably want to add.*/eslint-plugin-jsx-a11y/.*to[ignore]in your.flowconfig.Ahh ok that worked, thanks very much :)
@gaearon I don't have global ESlint, and I'm using VSCode, and I have this warning in both when working locally and the Tarvic CI is breaking because of this same warning :
Definition for rule 'jsx-a11y/alt-text' was not found jsx-a11y/alt-text, this occurred after updating toreact-script 1.0.7- locked and limited conversation to collaborators
on Jun 13, 2017
Known Issues:
Updates:
require.ensure()warning.require.ensure().Today I invite you to help us beta test
react-scripts@1.0.0for a few days before the public release.It used to be called
0.10but we figured there’s enough improvements to make it 1.0.To create a new app with it, run:
To upgrade an existing app, replace
"react-scripts": "0.9.5"in yourpackage.jsonwith:and run
npm install(oryarn).There is no changelog yet, but you can open the milestone to get a sense of included changes.
A few highlights:
import()(Add support for dynamic import & disable require.ensure #1538)envfiles (Feature/different env config files #1343 #1344)BROWSERvariable (Support node scripts in BROWSER #1590)srcrun now (Only run tests in <rootDir>/src (#544) #1808)publicfolder refreshes the page (Enable page reloading for files inpublic/#1546)There are a few more changes we plan to get into 1.0.0, but this should be enough the first public testing.
Please report any issues you bump into in this thread. We want this release to be as solid as possible, even though it’s unlikely we’ll keep it unreleased for much longer.
Big thanks to all the contributors. This will be our biggest release yet.