Skip to content

react-error-overlay: uncaught typeerror on using right/left arrow聽#2231

Closed
Closed
react-error-overlay: uncaught typeerror on using right/left arrow#2231
Labels
issue: bug

Description

@Gandem
Gandem
opened on May 19, 2017

Hello !

First of all thanks a lot for the upgrade and the hard work, create-react-app is completely awesome 馃槃 !

This issue was discovered when updating to react-scripts@1.0.0

Description

On launching an empty app created with create-react-app, and using right/left arrow on the keyboard (when no overlay error is present) it logs an error in the console:

Uncaught TypeError: Cannot read property 'error' of undefined
    at renderErrorByIndex (overlay.js:66)
    at switchError (overlay.js:86)
    at shortcutHandler (overlay.js:145)
    at keyHandler (shortcuts.js:17)

Reproducible Demo

I could reproduce this error on a new react project created with create-react-app, as well as old projects I upgraded.

For info, I'm on Mac OSX Sierra on Chrome 57.

I would be glad to send a Pull Request and work on this issue, if someone could give me some hints to what's actually happening on here !

Activity

  1. Gandem
    changed the title [-]react-error-overlay: uncaught typeerror on clicking right/left arrow[/-] [+]react-error-overlay: uncaught typeerror on using right/left arrow[/+] on May 19, 2017
  2. gaearon
    added
    issue: bug
    on May 19, 2017

  3. gaearon commented on May 19, 2017

    @gaearon
    gaearon
    on May 19, 2017
    Contributor

    Thanks! I鈥檒l take a look later today but if you find a quick fix send it our way.

  4. Timer
    added a commit that references this issue on May 19, 2017

    Ensure there's errors

    4783b68

  5. Timer commented on May 19, 2017

    @Timer
    Timer
    on May 19, 2017
    Contributor

    Fixed in #2238

  6. Timer
    closed this as completedon May 19, 2017

  7. gaearon commented on May 19, 2017

    @gaearon
    gaearon
    on May 19, 2017
    Contributor

    react-scripts@1.0.1 should be out with a fix.
    Can you please verify it helps?

  8. Gandem commented on May 19, 2017

    @Gandem
    Gandem
    on May 19, 2017
    ContributorAuthor

    Just upgraded to react-scripts@1.0.1 on some of my projects, and it worked perfectly. Thanks a lot 馃檶 !

  9. kobens commented on May 22, 2017

    @kobens
    kobens
    on May 22, 2017

    The fix doesn't seem to be working in react-scripts@1.0.3. I can see it's there, but when I look at the react-error-overlay package in my node_modules folder it has the correct version number (1.0.3), however, the fix is not present in the overlay.js file.

  10. gaearon commented on May 22, 2017

    @gaearon
    gaearon
    on May 22, 2017
    Contributor

    Oops, my fault. Will publish 1.0.4 soon.

  11. gaearon commented on May 22, 2017

    @gaearon
    gaearon
    on May 22, 2017
    Contributor

    Should be fixed in 1.0.4 (just published).

  12. lock
    locked and limited conversation to collaborators on Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    issue: bug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions