Repository navigation
Created app has wrong favicon "sizes" value in the manifest file, which results in console error. #3284
Description
Is this a bug report?
Yes
Can you also reproduce the problem with npm 4.x?
Did not try. Doesn't seem to be related to that.
Which terms did you search for in User Guide?
I didn't.
Environment
node -v: v8.7.0npm -v: 5.5.1yarn --version(if you use Yarn):npm ls react-scripts(if you haven’t ejected):
Then, specify:
- Operating system:
macOS 10.13 - Browser and version (if relevant):
Chrome 61
Steps to Reproduce
- Go to the created app's manifest file in public folder.
- The icons array has wrongly mentioned the favicon.ico size as 192x192 instead of 16x16 size of the included favicon file.
- Run the app. Go to Dev Tools' Application section. Open Manifest.
- Click Add to homescreen. This results in console error:
Error while trying to use the following icon from the Manifest: http://localhost:3000/favicon.ico (Resource size is not correct - typo in the Manifest?) Site cannot be installed: icon downloaded from the manifest was empty or corrupted
Expected Behavior
Should have searched for 144x144 image, where it would fail if we fix the size now.
Actual Behavior
Console error.
Reproducible Demo
Activity
Fix favicon sizes value in manifest
ryansully commentedon Oct 16, 2017
The included
favicon.icofile I found was 64x64 instead of 16x16, so I used that value in #3287.mohsinulhaq commentedon Oct 16, 2017
@ryansully yes, you are right, it's 64x64. My IDE wrongly showed it to be 16x16. My bad.
mohsinulhaq commentedon Oct 17, 2017
@ryansully have you signed the CLA here https://code.facebook.com/cla to get your PR approved?
ryansully commentedon Oct 17, 2017
That's odd, I've signed it and contributed before, should I sign again?
ryansully commentedon Oct 17, 2017
Actually, #3287 has the CLA Signed label:
#3287 (comment)
PR should be ready to go.
Fix favicon sizes value in manifest (#3287)
Fix favicon sizes value in manifest (react#3287)
camux commentedon Nov 8, 2018
I see this warning but icon size is 64x64 how remove this warning?
abhishekakade commentedon Nov 16, 2018
@camux, in your app, go to
publicfolder, right click onfavicon.icofile and selectProperties, thenDetailstab and checkDimensionsvalue. Then openmanifest.jsonfile (which is in the samepublicfolder) in a code editor and under"icons", change"sizes"value to whatever dimensions thefavicon.icofile had. That should fix the console error.Fix favicon sizes value in manifest (react#3287)