Skip to content

Convert RCTContextExecutor to use a dispatch queue instead of a thread #75

Description

@ide

This is a mostly straightforward task but may need some changes from Facebook's side if there is existing code calling into -[initWithJavaScriptThread:globalContextRef:]. The only tricky thing I see is the check in dealloc to see if the current thread is the JS thread. That could be replaced with dispatch_queue_set_specific and dispatch_get_specific, or dealloc could simply always dispatch_async. I'm also not sure it's needed at all since JSC should be thread-safe.

Activity

  1. ide commented on May 29, 2015

    @ide
    ContributorAuthor

    Closing this out because queues and run loops don't mix. Still wish we could use queues in the executor though.

  2. locked as resolved and limited conversation to collaborators on May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions