Skip to content

[Packager] Haste dependency regex is over-eager #88

Description

@ide

If you have method named require on an object and call it with something that looks like a path, Haste parses it and puts it in the module map. Instead it should look for object-less require calls and maybe explicitly allow global.require and window.require.

Repro: X.require('./hello')

Activity

  1. added
    Good first issueInterested in collaborating? Take a stab at fixing one of these issues.
    on May 29, 2015
  2. changed the title [-]Haste dependency regex is over-eager[/-] [+][Packager] Haste dependency regex is over-eager[/+] on May 31, 2015
  3. mkonicek commented on Mar 16, 2016

    @mkonicek
    Contributor

    Hi there! This issue is being closed because it has been inactive for a while.

    But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/packager-haste-dependency-regex-is-over-eager

    ProductPains helps the community prioritize the most important issues thanks to its voting feature.
    It is super simple to use - just login with GitHub.

    Also, if this issue is a bug, please consider sending a PR with a fix. We rely on the community to provide
    bugfixes as the core team is heavily focused working on performance.

  4. locked as resolved and limited conversation to collaborators on Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Good first issueInterested in collaborating? Take a stab at fixing one of these issues.Resolution: LockedThis issue was locked by the bot.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions