Repository navigation
fix: maintainVisibleContentPosition not compensating for height changes of first visible view - #55545
zhu-xiaowei wants to merge 1 commit into
Conversation
…es of first visible view The algorithm only compared the first visible view's origin before and after a mounting transaction. When the first visible view grows in size without changing its origin, content after it shifts but no scroll compensation was applied. This adds a size-change check that fires only when the origin delta is negligible, covering scenarios like streaming chat messages in inverted FlatLists, lazy-loaded images, and expandable content. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Hi @zhu-xiaowei! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@CalixTang has imported this pull request. If you are a Meta employee, you can view this in D93265420. |
|
How does this logic compare to comparing bottom of first frame? |
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
The algorithm only compared the first visible view's origin before and after a mounting transaction. When the first visible view grows in size without changing its origin, content after it shifts but no scroll compensation was applied. This adds a size-change check that fires only when the origin delta is negligible, covering scenarios like streaming chat messages in inverted FlatLists, lazy-loaded images, and expandable content.
Summary:
Changelog:
[General] [Fixed] - maintainVisibleContentPosition now compensates for size changes of the
first visible view, not just origin changes
Pick one each for the category and type tags:
[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
Test Plan: