Repository navigation
RFClarification: why is setState asynchronous? #11527
Description
Activity
We're all waiting @gaearon .
Reacted by Wilton Vieira, kelvinlieu12345 and kritidipto-1234Reacted by Connor Elsea, Alex Kam, Enrique Ballesté Peralta, Ayooluwa Isaiah, Belobobr, Alexis Navarro, Ankit Mishra, Ben Andrews, Val, Ammar Halees and 23 more@kaybarax Hey, it's weekend ;-)
Reacted by dan, swyx.io, Mathieu Savy, Kabir Baidhya, Taym Haddadi, Martín Varela, Miles O'Keefe, Juan Carlos Cancela, kitze 🚀, Connor Elsea and 26 more@mweststrate Oh! my bad. Cool.
I'm gonna go out on a limb here and say it's because of batching multiple
setStates in the same tick.Reacted by Connor Elsea, Emily Eisenberg, Junior Usca, Harm Meijer, Atte Juvonen, Jakub Łabno, kelvinlieu12345 and StephenI'm going on vacation next week but I'll probably go on Tuesday so I'll try to reply on Monday.
Reacted by battaile, Eugene, Аnton Krivokhizhin, Michel Weststrate, Andrew David Kay, Johnson, Sean M. Vieira, Thắng Nguyễn, Braden Snell, Adam Rackis and 46 moreReacted by Adam Walsh, Adam Rackis, julian libor, Augustus Yuan, John Darryl Pelingo, Connor Elsea, Lukasz Ostrowski, Astro, anubhavseal, Junior Usca and 13 morefunction enqueueUpdate(component) {
ensureInjected();// Various parts of our code (such as ReactCompositeComponent's
// _renderValidatedComponent) assume that calls to render aren't nested;
// verify that that's the case. (This is called by each top-level update
// function, like setState, forceUpdate, etc.; creation and
// destruction of top-level components is guarded in ReactMount.)if (!batchingStrategy.isBatchingUpdates) {
batchingStrategy.batchedUpdates(enqueueUpdate, component);
return;
}dirtyComponents.push(component);
if (component._updateBatchNumber == null) {
component._updateBatchNumber = updateBatchNumber + 1;
}
}Reacted by kimi013, 离佑, kelvinlieu12345 and Vinicius Vargas de OliveiraReacted by Decade, lsnch, Bryan Fonseca, Andre and Ted Johansson@mweststrate interestingly I asked the same question here: https://discuss.reactjs.org/t/historic-reasons-behind-setstate-not-being-immediately-visible/8487
I've personally had and seen in other developers confusion on this subject. @gaearon it'd be great to get an explanation for this when you have some time :)
Sorry, it's the end of the year and we've been a bit behind on GitHub etc trying to wrap up everything we've been working on before the holidays.
I do intend to come back to this thread and discuss it. But it's also a bit of a moving target because we're currently working on async React features that directly relate to how and when
this.stateis updated. I don't want to spend a lot of time writing something up, and then have to rewrite it because the underlying assumptions have changed. So I'd like to keep this open, but I don't know yet when I'll be able to give a definitive answer.Reacted by Braden Snell, Jason Quense, swyx.io, Robert Kielty, Augustus Yuan, John Darryl Pelingo, Raimundo Onetto, Drew Dennison, Daniel Reisel, Yangshun Tay and 18 moreSo here’s a few thoughts. This is not a complete response by any means, but maybe this is still more helpful than saying nothing.
First, I think we agree that delaying reconciliation in order to batch updates is beneficial. That is, we agree that
setState()re-rendering synchronously would be inefficient in many cases, and it is better to batch updates if we know we’ll likely get several ones.For example, if we’re inside a browser
clickhandler, and bothChildandParentcallsetState, we don’t want to re-render theChildtwice, and instead prefer to mark them as dirty, and re-render them together before exiting the browser event.You’re asking: why can’t we do the same exact thing (batching) but write
setStateupdates immediately tothis.statewithout waiting for the end of reconciliation. I don’t think there’s one obvious answer (either solution has tradeoffs) but here’s a few reasons that I can think of.Guaranteeing Internal Consistency
Even if
stateis updated synchronously,propsare not. (You can’t knowpropsuntil you re-render the parent component, and if you do this synchronously, batching goes out of the window.)Right now the objects provided by React (
state,props,refs) are internally consistent with each other. This means that if you only use those objects, they are guaranteed to refer to a fully reconciled tree (even if it’s an older version of that tree). Why does this matter?When you use just the state, if it flushed synchronously (as you proposed), this pattern would work:
console.log(this.state.value) // 0 this.setState({ value: this.state.value + 1 }); console.log(this.state.value) // 1 this.setState({ value: this.state.value + 1 }); console.log(this.state.value) // 2
However, say this state needs to be lifted to be shared across a few components so you move it to a parent:
-this.setState({ value: this.state.value + 1 }); +this.props.onIncrement(); // Does the same thing in a parent
I want to highlight that in typical React apps that rely on
setState()this is the single most common kind of React-specific refactoring that you would do on a daily basis.However, this breaks our code!
console.log(this.props.value) // 0 this.props.onIncrement(); console.log(this.props.value) // 0 this.props.onIncrement(); console.log(this.props.value) // 0
This is because, in the model you proposed,
this.statewould be flushed immediately butthis.propswouldn’t. And we can’t immediately flushthis.propswithout re-rendering the parent, which means we would have to give up on batching (which, depending on the case, can degrade the performance very significantly).There are also more subtle cases of how this can break, e.g. if you’re mixing data from
props(not yet flushed) andstate(proposed to be flushed immediately) to create a new state: #122 (comment). Refs present the same problem: #122 (comment).These examples are not at all theoretical. In fact React Redux bindings used to have exactly this kind of problem because they mix React props with non-React state: reduxjs/react-redux#86, reduxjs/react-redux#99, reduxjs/react-redux#292, reduxjs/redux#1415, reduxjs/react-redux#525.
I don’t know why MobX users haven’t bumped into this, but my intuition is that they might be bumping into such scenarios but consider them their own fault. Or maybe they don’t read as much from
propsand instead read directly from MobX mutable objects instead.So how does React solve this today? In React, both
this.stateandthis.propsupdate only after the reconciliation and flushing, so you would see0being printed both before and after refactoring. This makes lifting state up safe.Yes, this can be inconvenient in some cases. Especially for folks coming from more OO backgrounds who just want to mutate state several times instead of thinking how to represent a complete state update in a single place. I can empathize with that, although I do think that keeping state updates concentrated is clearer from a debugging perspective: #122 (comment).
Still, you have the option of moving the state that you want to read immediately into some sideways mutable object, especially if you don’t use it as a source of truth for rendering. Which is pretty much what MobX lets you do 🙂.
You also have an option to flush the entire tree if you know what you’re doing. The API is called
ReactDOM.flushSync(fn). I don’t think we have documented it yet, but we definitely will do so at some point during the 16.x release cycle. Note that it actually forces complete re-rendering for updates that happen inside of the call, so you should use it very sparingly. This way it doesn’t break the guarantee of internal consistency betweenprops,state, andrefs.To sum up, the React model doesn’t always lead to the most concise code, but it is internally consistent and ensures lifting state up is safe.
Enabling Concurrent Updates
Conceptually, React behaves as if it had a single update queue per component. This is why the discussion makes sense at all: we discuss whether to apply updates to
this.stateimmediately or not because we have no doubts the updates will be applied in that exact order. However, that needn’t be the case (haha).Recently, we’ve been talking about “async rendering” a lot. I admit we haven’t done a very good job at communicating what that means, but that’s the nature of R&D: you go after an idea that seems conceptually promising, but you really understand its implications only after having spent enough time with it.
One way we’ve been explaining “async rendering” is that React could assign different priorities to
setState()calls depending on where they’re coming from: an event handler, a network response, an animation, etc.For example, if you are typing a message,
setState()calls in theTextBoxcomponent need to be flushed immediately. However, if you receive a new message while you’re typing, it is probably better to delay rendering of the newMessageBubbleup to a certain threshold (e.g. a second) than to let the typing stutter due to blocking the thread.If we let certain updates have “lower priority”, we could split their rendering into small chunks of a few milliseconds so they wouldn’t be noticeable to the user.
I know performance optimizations like this might not sound very exciting or convincing. You could say: “we don’t need this with MobX, our update tracking is fast enough to just avoid re-renders”. I don’t think it’s true in all cases (e.g. no matter how fast MobX is, you still have to create DOM nodes and do the rendering for newly mounted views). Still, if it were true, and if you consciously decided that you’re okay with always wrapping objects into a specific JavaScript library that tracks reads and writes, maybe you don’t benefit from these optimizations as much.
But asynchronous rendering is not just about performance optimizations. We think it is a fundamental shift in what the React component model can do.
For example, consider the case where you’re navigating from one screen to another. Typically you’d show a spinner while the new screen is rendering.
However, if the navigation is fast enough (within a second or so), flashing and immediately hiding a spinner causes a degraded user experience. Worse, if you have multiple levels of components with different async dependencies (data, code, images), you end up with a cascade of spinners that briefly flash one by one. This is both visually unpleasant and makes your app slower in practice because of all the DOM reflows. It is also the source of much boilerplate code.
Wouldn’t it be nice if when you do a simple
setState()that renders a different view, we could “start” rendering the updated view “in background”? Imagine that without any writing any coordination code yourself, you could choose to show a spinner if the update took more than a certain threshold (e.g. a second), and otherwise let React perform a seamless transition when the async dependencies of the whole new subtree are satisfied. Moreover, while we’re “waiting”, the “old screen” stays interactive (e.g. so you can choose a different item to transition to), and React enforces that if it takes too long, you have to show a spinner.It turns out that, with current React model and some adjustments to lifecycles, we actually can implement this! @acdlite has been working on this feature for the past few weeks, and will post an RFC for it soon.
Note that this is only possible because
this.stateis not flushed immediately. If it were flushed immediately, we’d have no way to start rendering a “new version” of the view in background while the “old version” is still visible and interactive. Their independent state updates would clash.I don’t want to steal the thunder from @acdlite with regards to announcing all of this but I hope this does sound at least a bit exciting. I understand this still might sound like vaporware, or like we don’t really know what we’re doing. I hope we can convince you otherwise in the coming months, and that you’ll appreciate the flexibility of the React model. And as far as I understand, at least in part this flexibility is possible thanks to not flushing state updates immediately.
Reacted by Juan David Castro, Jakub, Pablo Fernández, Jeremy Martin, Matthew Brooks, Juuso Meriläinen, Chad Smith, Sam Horton, Braden Snell, Mark Erikson and 1501 moreReacted by Akimov Vladimir, Vernon de Goede, Taym Haddadi, Chang Yan, 月熊造物 | Lunacrest Maker, Dmitrii Melnikov, Ronaldo Campos, Dhruvdutt Jadhav, Josh Manders, Radu Pacurar Vasile and 112 moreReacted by Jed Fox, Eugene, Akimov Vladimir, Varenya Thyagaraj, Travis Crumley, Vernon de Goede, Taym Haddadi, John Darryl Pelingo, Chang Yan, JayChung and 175 moreReacted by Eugene, Akimov Vladimir, Taym Haddadi, 月熊造物 | Lunacrest Maker, Ronaldo Campos, jose, Justin McCarthy, Joe Wright, Igor Blinnikov, hhw3KevinHou and 42 moreReacted by Eli Perkins, Jeremy Martin, Matthew Brooks, Sam Horton, Mark Erikson, Adam Walsh, Josh Ghoulberg 👻, Mauro Gestoso, Spencer Schneidenbach, Daniel Thompson and 366 moreReacted by neo, Vasilis Diakomanolis, Szabó Zsolt, Robin Métral, Ilya, carrie, Chris Han, Tarek Kalaji, Syed Waqas, Vladyslav and 88 moreReacted by Vladyslav, pranav2308, Mumu, Elkin Alberto, steve720zhang, Thang Nguyen, Moein Alizadeh, J1uT0ng, Junior Usca, Everton Miranda Vitorio and 57 moreWonderful in depth explanation to the decisions behind the architecture of React. Thanks.
Reacted by Terminalqo, Jayesh Tiwari, fxyi, Abbas Hosseini, Rahul Gupta, Arnim, kelvinlieu12345, Tomáš Šesták, Changpeng Ke and Yurii Khvyshchukmark
Reacted by Philip, Oleg Grishechkin and kelvinlieu12345Reacted by Daniil Demidovich, Dan Scanlon, Edward Dewhurst, Mihir Sanghavi, cybai (Haku), Michael Standen, Philipp Spiess, Ron Hsu, Bryan Gilbraith, wk-j and 53 moreReacted by Github User and Om RajReacted by Mukhtar Bahadory13 remaining items
Awesome!
That question & answer should be documented somewhere more reachable. Thank you guys enlightening us.
Reacted by Nick Ribal, Decade, Łukasz Wojciechowski, iamcastelli, Mirko Kirović, Dan Lourenço and Abbas HosseiniLearned a lot . Thanks
Trying to add my point of view to the thread. I work on an app based on MobX some months, I have been exploring ClojureScript for years and made my own React alternative(called Respo), I tried Redux in the early days although very short time, and I'm betting on ReasonML.
The core idea in combining React and Functional Programming(FP) is you got a piece of data you can render it into a view with whatever skills you have that obeys the laws in FP. You got no side-effects if you only use pure functions.
React is not pure functional. By embracing local states inside components, React has the power of interacting with various libraries related to DOM and other browser APIs(also friendly to MobX), which meanwhile makes React impure. However, I tried in ClojureScript, if React is pure, it could be disaster since it's really hard to interact with so many existing libraries that has side-effects in them.
So in Respo(my own solution), I had two goals that seem conflicted, 1)
view = f(store)so no local state is expected; 2) I don't like to program all component UI states in global reducers since that could be hard for maintaining. At end, I figured out I need a syntax sugar, which helps me maintain components states in a global store withpaths, meanwhile I write state updates inside component with Clojure macros.So what I learnt: local states is a developer experience feature, underneath we want global states which enables our engines to perform optimisations in deep levels. So, MobX people prefer OOP, is that for developer experience, or for engines?
Reacted by crapthingsBy the way I gave a talk about the future of React and its async features, in case you missed it:
https://reactjs.org/blog/2018/03/01/sneak-peek-beyond-react-16.htmlReacted by cybai (Haku), 题叶, Reuben Antz, Peng WeiHong, Milad, Sheryl Hohman, Martin Bohgard, Ofer Morag, Barry, tmax and 1 moreDan,you are my idol.....thanks a lot.
Reacted by kedayaReacted by Danylo FedorovWindRunnerMax commented
on Dec 25, 2020 on Dec 25, 2020 · Hidden as off-topicshow commentMore actionsthank u dan
mark
thanks dan
mark react async render
For example, if we’re inside a browser click handler, and both Child and Parent call setState, we don’t want to re-render the Child twice, and instead prefer to mark them as dirty, and re-render them together before exiting the browser event.
where should I find the
mark them as dirtypoint in react code?@mweststrate @gaearon Should we call setState is asynchronous? As I know, react render works asynchronously, but setState function is not async itself.
@mweststrate @gaearon Should we call setState is asynchronous? As I know, react render works asynchronously, but setState function is not async itself.
setState is not a async function, but it's kinda "asynchronious" since the effect is delayed. Async programming is way older than when javascript got the
async/awaitkeywords, or even the concept of aPromisewhich is what we think of nowadays as "async"Reacted by 𝑵𝒂𝒎𝒏𝒊𝒌𝒂 𝑱𝒂𝒏𝒃𝒂𝒏𝒅𝒉𝒖, Bryan Fonseca, Qwerty (Vítězslav Ackermann Ferko) and LenonReacted by Lenon
For quite a while I've tried to understood why
setStateis asynchronous. And failing to find an answer to it in the past, I came to the conclusion that it was for historical reasons and probably hard to change now. However @gaearon indicated there is a clear reason, so I am curious to find out :)Anyway, here are the reasons I often hear, but I think they can't be everything as they are too easy to counter
Async setState is required for async rendering
Many initially think it is because of render efficiency. But I don't think that is the reason behind this behavior, because keeping setState sync with async rendering sounds trivial to me, something along the lines of:
In fact, for example
mobx-reactallows synchronous assignments to observables and still respect the async nature of renderingAsync setState is needed to know which state was rendered
The other argument I hear sometimes is that you want to reason about the state that was rendered, not the state that was requested. But I'm not sure this principle has much merit either. Conceptually it feels strange to me. Rendering is a side effect, state is about facts. Today, I am 32 years old, and next year I will turn 33, regardless whether the owning component manages to re-render this year or not :).
To draw a (probably not to good) parallel: If you wouldn't be able to read your last version of a self written word document until you printed it, that would be pretty awkward. I don't think for example game engines give you feedback on what state of the game was exactly rendered and which frames were dropped either.
An interesting observations: In 2 years
mobx-reactnobody ever asked me the question: How do I know my observables are rendered? This question just seems not relevant very often.I did encounter a few cases where knowing which data was rendered was relevant. The case I remember was where I needed to know the pixel dimensions of some data for layout purposes. But that was elegantly solved by using
didComponentUpdateand didn't really rely onsetStatebeing async either. These cases seem so rare that it hardly justify to design the api primarily around them. If it can be done somehow, it suffices I thinkI have no doubt that the React team is aware of the confusion the async nature of
setStateoften introduces, so I suspect there is another very good reason for the current semantics. Tell me more :)