Repository navigation
Overriding HttpServer::MAXIMUM_BUFFER_SIZE #436
Description
Activity
Fixed by explicitly passing middleware objects to HttpServer:
$requestMaxSize = $this->iniSizeToBytes($this->requestMaxSize); $memoryLimit = $this->iniSizeToBytes($this->memoryLimit); $requestHandlers = []; $requestHandlers[] = new StreamingRequestMiddleware(); $concurrency = $this->getConcurrentRequestsLimit($memoryLimit, $requestMaxSize); if ($concurrency !== null) { $requestHandlers[] = new LimitConcurrentRequestsMiddleware($concurrency); } $requestHandlers[] = new RequestBodyBufferMiddleware($requestMaxSize); if ($this->enablePostDataReading) { $requestHandlers[] = new RequestBodyParserMiddleware(); } $requestHandlers[] = $callback; return new React\Http\HttpServer(...$requestHandlers);Hey @hast, thanks for opening this up 👍
It seems like you already found your way of dealing with this, a similar approach can be found inside the documentation. You can also take a look at #371.
Reacted by Oleksandr Zahorulia
Hello. I just upgraded from 0.8.7 to 1.5.0. Before the upgrade, we could accept requests up to 10MB. But now all the requests are always being cut. The problem is that
LimitConcurrentRequestsMiddlewareused to operate INI'spost_max_sizesettings, and now it's limited byHttpServer::getMaxRequestSize(), and its result can not be higher thanHttpServer::MAXIMUM_BUFFER_SIZE. Is there any workaround to accept heavy packages?RequestBodyBufferMiddleware has a solution for this (it ignores sizeLimit if an actual size is higher):
But
LimitConcurrentRequestsMiddlewareis always being limited to MAXIMUM_BUFFER_SIZE.I find the logic pretty unclear, because
RequestBodyBufferMiddlewaredoes accept packages higher than MAXIMUM_BUFFER_SIZE, but at the same time it's always limited due toLimitConcurrentRequestsMiddleware.