Repository navigation
Is JSON::Coder intended to be thread safe ? #1064
Description
Activity
I also looked into this a little bit and could find no documentation one way or another about using a single Coder instance concurrently across threads.
I believe this issue affects both the Java code and the C code, but the C code might only expose it if some object implements part of its dumping in Ruby.
Is JSON::Coder intended to be thread safe ?
Yes, one of the goal of
JSON::Coderis to not have to reparse options on every call,hence it needs to be shareable between threads and e able to be used concurrently.I some how can't find the commit anymore but we had one such bug in the past that we fixed.
The struct/object that holds the
current_nestingshould be duped at the start ofparseandgenerate(or be kept in a separate object.@byroot Thanks for the background info. We'll look into fixing the JRuby
Coderto be thread-safe.FWIW I tihnk there's still an issue in CRuby if dumping requires a call back into Ruby, since that could trigger a context switch and parallel updating of the
Coderdepth.
In JRuby we hit a race condition: ActiveSupport uses a single shared
JSON::Coderinstance and calls
#dumpon it from multiple threads.ActiveSupport creates one shared Coder:
https://github.com/rails/rails/blob/v8.1.3.1/activesupport/lib/active_support/json/encoding.rb#L152
…and reuses it on every encode:
https://github.com/rails/rails/blob/v8.1.3.1/activesupport/lib/active_support/json/encoding.rb#L188
The error we got, on a flat object was
JSON::NestingError: nesting of 100 is too deep. Did you try to serialize objects with circular references?Question: is a single
JSON::Coderinstance intended to be safe to callconcurrently from multiple threads (i.e. is
#dump/#generateon one Coderintended to be thread-safe)?
Versions: json 2.21.2 (java), JRuby 10.0.5.0, activesupport 8.1.3.1.
I have a small threaded reproduction I can add if useful.