Skip to content

exp_string should take String. #34

Description

@cheako

I don't know how ppl feel about API changes, I'd guess there are so few users it doesn't matter as long as the minor version id bumped appropriately.

APIs should take owned values when they need an owned clone of something, instead of calling to_owned() or in this case to_string().

See: https://www.philipdaniels.com/blog/2019/rust-api-design/

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions