Fix media key skip behavior - #272
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for skip forward/backward remote commands (Control Center / media keys) in the now playing manager, with behavior configurable based on the user's media control style setting.
Changes:
- Registers
skipForwardCommandandskipBackwardCommandhandlers with a default 15-second interval. - Adds teardown for the new commands and a unified
handleSkipCommandhelper that either invokes next/previous or seeks by the requested interval. - Introduces a
SkipDirectionenum and a shareddefaultSkipIntervalconstant.
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b536bfeca
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Description
Ensure media key skip actions advance to the next track (instead of restarting) when Kaset is in the background by handling skip forward/back remote commands and routing them based on the selected media control style.
AI Prompt
馃 AI Prompt Used
AI Tool: GitHub Copilot (GPT-5.2-Codex)
Type of Change
Related Issues
Fixes #255
Changes Made
MPRemoteCommandCenter.Testing
swift buildswiftlint --strict && swiftformat .swift test(runTests tool; all passed)Checklist
swiftlint --strict && swiftformat .