Repository navigation
Fix panic when a YAML config has a non-string map key - #5259
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
stringifyYAMLMapKeysconverts themap[any]anyvalues that the YAML decoder returns for maps with non-string keys intomap[string]any. It asserts each key is astring, so a config such asenv: {1: one}or atrue:key panics withinterface conversion: interface {} is int, not stringinLoadConfigandLoadConfigAsMap.How: Format the key with
fmt.Sprintinstead of asserting its type, so1becomes"1", which matches how TOML and JSON configs treat keys. Adds a test that loads and strictly maps a YAML config with an integer key and a boolean key.Related to: none
Documentation
Fixes #5258