Skip to content

refactor(rsc): use Vite ESTree types - #1347

Closed
hi-ogawa wants to merge 1 commit into
mainfrom
vite-estree
Closed

hi-ogawa wants to merge 1 commit into
mainfrom
vite-estree

Conversation

@hi-ogawa

@hi-ogawa hi-ogawa commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

A bit of churns with custom packages/plugin-rsc/src/transforms/estree.ts but probably good first step.

Summary:

  • consolidate ast types used by rsc transforms against Vite 8’s exported ESTree namespace instead of @types/estree.
  • we still rely on estree-walker but uses it by wrapping with Vite AST types.

TODO:

Co-authored-by: OpenCode <noreply@opencode.ai>
@hi-ogawa
hi-ogawa marked this pull request as draft July 29, 2026 08:48

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still need to ask agent why this is legit with comments

@hi-ogawa

Copy link
Copy Markdown
Contributor Author

@hi-ogawa hi-ogawa closed this Jul 30, 2026
@hi-ogawa
hi-ogawa deleted the vite-estree branch September 4, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant