Skip to content

Bot doesn't comment in PRs when autostarting CI #175

Description

@richardlau

As per #173 (comment) currently the Bot doesn't comment in PRs when autostarting CI.

If we start relying on the autostarted CI rather than manual runs, then if we land PRs without merging no evidence will be left that CI was run at all.

Activity

  1. phillipj commented on Jun 9, 2018

    @phillipj
    Member

    @maclover7 would you mind elaborating a bit what you meant with "faulty Jenkins logic"? Is this is flaw in the bot or how Jenkins reports build statuses?

  2. maclover7 commented on Jun 9, 2018

    @maclover7
    Contributor

    @richardlau @phillipj Sorry for not being more specific -- this is a flaw in how ci.nodejs.org works. The way the CITGM logic works is because Jenkins will redirect to the newly created job after creation. This does not happen for node-test-pull-request-lite since it is not a pipeline job, it only redirects to the job's "home page". I will be taking a look to converting the lite job to a pipeline in the coming days

  3. phillipj commented on Jun 9, 2018

    @phillipj
    Member

    Ahh thanks, good to hear improvements are on the way 👍

  4. added a commit that references this issue on Jun 9, 2018
  5. maclover7 commented on Jun 9, 2018

    @maclover7
    Contributor

    Fixed in #178, #180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions