Repository navigation
jenkins: comment correct url - #180
Merged
Merged
Conversation
Was posting the API url for the build, now posts the correct Blue Ocean url for the build. Changes environment variable since we do not know what the url for the build will be based on the API response.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
Thank you for all of your help @phillipj, I really appreciate it! |
Contributor
Author
|
It Works: nodejs/node#21236 (comment) 🎉 |
maclover7
added a commit
to nodejs/build
that referenced
this pull request
Jun 9, 2018
Storing name of job, not URL anymore PR-URL: #1328 Refs: https://github.com/nodejs-private/secrets/pull/21 Refs: nodejs/github-bot#180 Reviewed-By: Phillip Johnsen <johphi@gmail.com>
Member
|
My pleasure, great having someone to work on the bot with 👍 |
This was referenced Jun 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was posting the API url for the build, now posts the
correct Blue Ocean url for the build.
Changes environment variable since we do not know what the url for the
build will be based on the API response.