Repository navigation
gh-94751: Install, import and run the test C++ extension (MVP) - #94754
Conversation
- Run test functions on import (yes, this can definitely be improved) - Fudge setuptools metadata (name & version) to make the extension installable - Install and import the extension in test_cppext
|
It looks good to me as based on a quick read through. I think it's definitely worth running the tests rather than assuming that it's fine if it compiles. It looks like |
|
Thank you!
Yes. I filed #94755 for the future improvement. |
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
…ythonGH-94754) This is a quick-and-dirty way to run the C++ tests. It can definitely be improved in the future, but it should fail when things go wrong. - Run test functions on import (yes, this can definitely be improved) - Fudge setuptools metadata (name & version) to make the extension installable - Install and import the extension in test_cppext (cherry picked from commit ec5db53) Co-authored-by: Petr Viktorin <encukou@gmail.com>
|
GH-94780 is a backport of this pull request to the 3.11 branch. |
|
I'm seeing segfaults on from test_cppext on what should be an unrelated PR https://github.com/python/cpython/runs/7316060423?check_suite_focus=true |
) (#94780) This is a quick-and-dirty way to run the C++ tests. It can definitely be improved in the future, but it should fail when things go wrong. - Run test functions on import (yes, this can definitely be improved) - Fudge setuptools metadata (name & version) to make the extension installable - Install and import the extension in test_cppext (cherry picked from commit ec5db53) Co-authored-by: Petr Viktorin <encukou@gmail.com>
|
You've accidentally included the failing reproducer in that unrelated PR. Context switching is hard! Thanks for doing it to come up with the reproducer :) |
This is a quick-and-dirty way to run the C++ tests. It can definitely be improved in the future, but it should fail when things go wrong.