Skip to content

[3.11] gh-94751: Install, import and run the test C++ extension (MVP) (GH-94754) - #94780

Merged
encukou merged 1 commit into
python:3.11from
miss-islington:backport-ec5db53-3.11
Jul 13, 2022
Merged

encukou merged 1 commit into
python:3.11from
miss-islington:backport-ec5db53-3.11

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 12, 2022 •

Copy link
Copy Markdown
Contributor

This is a quick-and-dirty way to run the C++ tests.
It can definitely be improved in the future, but it should fail when things go wrong.

  • Run test functions on import (yes, this can definitely be improved)
  • Fudge setuptools metadata (name & version) to make the extension installable
  • Install and import the extension in test_cppext
    (cherry picked from commit ec5db53)

Co-authored-by: Petr Viktorin encukou@gmail.com

…ythonGH-94754)

This is a quick-and-dirty way to run the C++ tests.
It can definitely be improved in the future, but it should fail when things go wrong.

- Run test functions on import (yes, this can definitely be improved)
- Fudge setuptools metadata (name & version) to make the extension installable
- Install and import the extension in test_cppext
(cherry picked from commit ec5db53)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@miss-islington

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 12, 2022
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 1ab009d 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 12, 2022
@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .

17 similar comments
@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

@encukou
encukou merged commit ffbd6ae into python:3.11 Jul 13, 2022
@miss-islington
miss-islington deleted the backport-ec5db53-3.11 branch July 13, 2022 09:09
@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .

2 similar comments
@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .

10 similar comments
@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants