Repository navigation
eslint ignores variables named status #1834
Description
Activity
As I understand it is expected behavior since
statusis awindowproperty (https://developer.mozilla.org/en-US/docs/Web/API/Window/status) and we configure eslint env. browser on eslint-config-react-app/index.js#L29It's still confusing and IMO we should forbid implicit
windowproperties withoutwindow.qualifier.Reacted by Jirat Ki.I think eslint doesn't support that.
See eslint/eslint#3959 .
It seems like we would have to remove browser env and add a list of some variables to globals likelocalStorage.I don't mind having our own list of globals.
I can work on this.
Sounds good!
- added this to the milestone
on Mar 27, 2017 I think I was wrong about this. People are genuinely confused when “valid” globals don’t work—especially if they’re built into the browser.
I propose another strategy. Let’s go through the list of globals and pick a list of names that can genuinely be confused with local variables (e.g.
statusis a great candidate). It’s gonna be subjective but I’m okay with that.- locked and limited conversation to collaborators
on Jan 21, 2019
Can you reproduce the problem with latest npm?
yes. npm version: 4.1.1
Description
Linter ignores
statusvariable name when checking for unused vars.Not sure if this is a bug or expected behaviour.
Expected behavior
It should probably warn when I have not declared a variable named
statusand have this line of code:console.log(status)Actual behavior
Even though I have not declared any variable named
status,using it does not show any warning or errors.
it shows
no-undeferror on all other variables names likestatussas expectedEnvironment
Run these commands in the project folder and fill in their results:
npm ls react-scripts(if you haven’t ejected): 0.9.0node -v: v7.7.1npm -v: 4.4.1Then, specify:
Reproducible Demo
create a new app with:
create-react-app test-appIn index.js type:
console.log(status)It won't show any error that status is not defined but changing the variable name to
statusswould show error as expected