Repository navigation
Master crashes when opening two apps (and port conflicts) #2112
Description
Activity
This regression was introduced when we fixed the behavior of our
HOSTbinding.detect-portdoes not support specifying an address to check on, so we need to switch packages or send a PR upstream to add the functionality.tl;dr we listen on
127.0.0.1,detect-portchecks on0.0.0.0Filed an issue upstream: node-modules/detect-port#19.
Hmm. If we're listening on 127.0.0.1, does it mean access from local network doesn't mean by default anymore? This seems frustrating. Why did we change this?
We've always said we're listening on localhost which implies we're not listening on the entire local network. Mainly, it was done out of interest in security (since we proxy API calls which are going to be elevated during development).
Previously we said
localhostbut actually listened on0.0.0.0.I'm not opposed to listening to
0.0.0.0by default.- added this to the milestone
on May 10, 2017 I'd prefer we keep the existing behavior with using 0.0.0.0 as a default. I'm cool with printing 0.0.0.0 to the console in this case for posterity.
Fair enough, the 0.9.x branch currently does this (and prints
0.0.0.0). I'll send a PR.Um. I still don't quite get it. Can we just revert to old behavior in the meantime? Or was that fix important?
It's important because HOST doesn't work otherwise, the issue was already fixed in detect port so we just have to update the dependency and this should start working again.
Okay. Can you take care of this?
- locked and limited conversation to collaborators
on Jan 21, 2019
This is some new issue.