Upgrade detect-port

[Timer]

Upgrades detect port to resolve #2112.

Test plan: start two servers and expect the duplicate message, do the same with a different HOST.
It works.

I'm not sure about edge cases (like binding to a hostname instead of address, e.g. boop.local).

[gaearon]

Not working for me.

[Timer]

Weird.. I wonder what differs between our macs.
I'll look at this again in a few.

[gaearon]

The stack is weird, isn't it? Doesn't seem to be inside the initial promise code.

[gaearon]

This doesn't work for me:

  // 1. check 0.0.0.0
  listen(port, null, (err, realPort) => {

This does:

  // 1. check 0.0.0.0
  listen(port, '0.0.0.0', (err, realPort) => {

[Timer]

Ooo. Maybe the latest release introduced a regression.
I'll be able to check it out in a bit.

To be fair, I ran the first application using an older CRA.

[Timer]

Yeah, that's because null binds to :: by default (IPv6), which also binds to 0.0.0.0 in a fallback-ish-way.

I asked again for the original request, which is to let us explicitly pass which host we'd like to check.

The testing was my bad, it was because the old CRA version bound to a different address (which let detect-port work with its patch).

[gaearon]

What's the conclusion? How do we fix?

[Timer]

We can either revert this behavior entirely (breaking HOST), we can add logic to bind to IPv6 by default (when available, still doesn't fix the underlying issue but most cases), or wait for another release of detect-port.

[Timer]

We could also just fork detect-port for our own use.

[gaearon]

I'm okay with temporarily forking.