You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Oh so --set simply creates an object accessed via .Insecure.User. Can't we have it that it completely overwrites any of the template data? This part is only used in step certificate so presumably the user wants much more control than step ca, so it shouldn't be "Insecure"
Oh so --set simply creates an object accessed via .Insecure.User. Can't we have it that it completely overwrites any of the template data? This part is only used in step certificate so presumably the user wants much more control than step ca, so it shouldn't be "Insecure"
For consistency with other commands we should keep the --set, --set-file, and .Insecure.User as they are, so you can use the same templates.
Regarding using a flag to manually edit the configuration, that's a nice option, it won't be --set but it can be something similar.
With the hints from this PR, I think I can come up with something of that sort. Just need to edit data with the appropriate input. I'll see what I can do this weekend
With the hints from this PR, I think I can come up with something of that sort. Just need to edit data with the appropriate input. I'll see what I can do this weekend
@LecrisUT using data won't work directly, because that's the information available to the template, you want something that works after rendering the template, either on the template itself (probably easier) or over the resulting x509util.Certificate or x509util.CertificateRequest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs triageWaiting for discussion / prioritization by team
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows to use user variables in the templates used in
step certificate createandstep certificate sign.Fixes #719